Review Board 1.7.22


[HBASE-4476] Compactions must fail if column tracker gets columns out of order

Review Request #2050 - Created Sept. 26, 2011 and updated

Mikhail Bautin
HBASE-4476
Reviewers
hbase
kannanm
hbase
We found this in ScanWildcardColumnTracker:

// new col < oldcol
// if (cmp < 0) {
// WARNING: This means that very likely an edit for some other family
// was incorrectly stored into the store for this one. Continue, but
// complain.
LOG.error("ScanWildcardColumnTracker.checkColumn ran " +
"into a column actually smaller than the previous column: " +

This went under the radar in our dark launch cluster when a column family name was misspelled first, but then was "renamed" by renaming directories in the HBase storage directory tree. We ended up with inconsistent data, but compactions still succeeded most of the time, likely discarding part of input data.
Run unit tests.
Will also push to a 5-node dev cluster.
Review request changed
Updated (Sept. 29, 2011, 11:45 p.m.)
Linking to HBASE-4476.
Ship it!
Posted (Sept. 30, 2011, 8:56 p.m.)

   

  
Ship it!
Posted (Sept. 30, 2011, 9:16 p.m.)