Review Board 1.7.22


Add <uses> and <export type="rpc"> elements to features which call or register RPC endpoints

Review Request #2038 - Created Sept. 23, 2011 and submitted

Ryan Baxter
SHINDIG-1629
Reviewers
shindig
johnfargo
shindig
The uses elements can be used to secure which RPC endpoints gadgets will be allowed to call. The export elements are not used currently but we should add them for completeness.
Ran unit tests
Review request changed
Updated (Sept. 23, 2011, 5:03 p.m.)
  • 
    	  

    Ran unit tests
Ship it!
Posted (Sept. 23, 2011, 8:05 p.m.)
LGTM

Out of curiosity, how did you determine all of the uses?
  1. Brut force :)  I searched for gadgets.rpc.call for the uses and searched for gadgets.rpc.register and osapi.container.Container.rpcRegister for the exports.
Ship it!
Posted (Sept. 23, 2011, 8:18 p.m.)
LGTM
Ship it!
Posted (Sept. 26, 2011, 4:06 p.m.)
Committed revision 1175925.