Review Board 1.7.22


ZOOKEEPER-1199: Make OpCode an enum

Review Request #2015 - Created Sept. 22, 2011 and updated

Thomas Koch
ZOOKEEPER-1199
Reviewers
zookeeper
zookeeper-git
There are four places in the ZK code, that mapped OpCodes to string representations. One of them wasn't used anymore, two others represented the same mapping and the last one provided four letter representations. As you can see in the definition of the OpCode enum, there were strings missing for some newer added OpCodes. You might want to say, which strings I should put in?
I spotted an inconsistency in server/quorum/ReadOnlyRequestProcessor.java. There's a switch checking for a write operation which does not include multi, start- and stopsession. What is intended there?

 
Review request changed
Updated (Oct. 25, 2011, 4:51 p.m.)
centralized the logic to deserialize requests in PrepRequestProcessor and FinalRequestProcessor