Review Board 1.7.22


Using COR function in Piggybank results in ERROR 2018: Internal error. Unable to introduce the combiner for optimization

Review Request #1929 - Created Sept. 16, 2011 and updated

Daniel Dai
PIG-2286
Reviewers
pig
thejas
pig
See PIG-2286
Unit-test:
    all pass

Piggybank-test:
    TestDBStorage fail for other reason, unrelated to patch

Test-patch:
     [exec] +1 overall.  
     [exec] 
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec] 
     [exec]     +1 tests included.  The patch appears to include 3 new or modified tests.
     [exec] 
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec] 
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec] 
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec] 
     [exec]     +1 release audit.  The applied patch does not increase the total number of release audit warnings.
Posted (Sept. 20, 2011, 6:11 p.m.)

   

  
I think a comment will be useful - 
// The algebraic udf can have more than one input. Add the udf only once
The size of the tuple would need to be size*(size-1).
Details -
the inner loop is executed - (n-1) + (n-2) + .. (n - (n-1)) = n(n-1)/2 . 
Each time the inner loop is executed two columns are being added. So 2 * n(n-1)/2 = n(n-1)
I don't understand why the values are being added to a tuple as columns. That does not look right.