Review Board 1.7.22


PIG-2228: support partial aggregation in map task

Review Request #1817 - Created Sept. 12, 2011 and updated

Thejas Nair
PIG-2228
Reviewers
pig
daijy, dvryaboy
pig
See PIG-2228
test-patch 
     [exec] -1 overall.
     [exec]
     [exec]     +1 @author.  The patch does not contain any @author tags.
     [exec]
     [exec]     +1 tests included.  The patch appears to include 21 new or modified tests.
     [exec]
     [exec]     +1 javadoc.  The javadoc tool did not generate any warning messages.
     [exec]
     [exec]     +1 javac.  The applied patch does not increase the total number of javac compiler warnings.
     [exec]
     [exec]     +1 findbugs.  The patch does not introduce any new Findbugs warnings.
     [exec]
     [exec]     -1 release audit.  The applied patch generated 461 release audit warnings (more than the trunk's current 455 warnings).
release audit failures are because of jdiff changes

All  unit tests pass, new e2e tests added .
Review request changed
Updated (Sept. 15, 2011, 5:27 p.m.)
New patch addressing code review comments.
Ship it!
Posted (Sept. 15, 2011, 5:28 p.m.)

   

  
Ship it!
Posted (Sept. 15, 2011, 5:38 p.m.)
lgtm assuming you tested the heck out of this
?
Posted (Sept. 15, 2011, 5:53 p.m.)

   

  
removed the extra ";" in the patch checked in.