Review Board 1.7.22


Declared actions get fired in the first instance of the gadget, ignoring any specified view target in the declaration

Review Request #1682 - Created Aug. 30, 2011 and submitted

Dan Dumont
SHINDIG-1607
Reviewers
shindig
mhatem, rbaxter, ssievers
shindig
It looks like the current impl of declarative actions pick the first gadget site where the URL matches and fires the action in that.  The actions spec lets you specify a target view, so we should make sure to check if the site has that view rendered.   It may also be rendered more than once, so we should fire the action in all of them.

 
Review request changed
Updated (Sept. 2, 2011, 1:19 p.m.)
Now that actions have been fixed, the voip gadget was broken because it was declaring an action with a view target it did not have.

Removing the view attribute on the declared actions solved the issue Ryan was seeing.
Ship it!
Posted (Sept. 2, 2011, 1:35 p.m.)
Committed revision 1164527.  Please close the review and the JIRA.