Review Board 1.7.22


HBASE-4117: Slow Query Log and Client Operation FIngerprints

Review Request #1621 - Created Aug. 22, 2011 and updated

Riley Patterson
HBASE-4117
Reviewers
hbase
hbase
Exposes JSON-parseable fingerprint and details for queries that take longer than a configurable threshold time. The exposure is currently to the main regionserver log, along with a (operationTooSlow) tag which allows it to be grepped out and easily aggregated and/or monitored in administrator scripts.

The patch also provides a standard way to extract fingerprint and detail information of interest by requiring each "Operation" to provide a fingerprint map and a details map, which will be a superset of the fingerprint. 
Monitored get and put latency with and without the patch using reasonable hbase.ipc.warn.response.time settings (1000ms, 2000ms). Performance was not noticeably impacted.
Review request changed
Updated (Aug. 26, 2011, 4 a.m.)
Several code-cleanup related changes.
Ship it!
Posted (Aug. 27, 2011, 3:46 a.m.)

   

  
Why remove this stuff Riley?  Seems useful?  Or, looks like you moved it.  What you thinking?  Move it out of the generic into the specific implementation engine?
nice

Doing check for both too large and too slow

I suppose this answers my previous question.