Review Board 1.7.22


SQOOP-1258 Sqoop2: FrameworkMetadataUpgrade can't handle new inputs

Review Request #16112 - Created Dec. 8, 2013 and updated

Jarek Cecho
SQOOP-1258
Reviewers
Sqoop
sqoop-sqoop2
I've fixed the issue by providing try-catch block as is done in the GenericJDBCConnector upgrader.
Tested on real cluster as a part of testing SQOOP-1254. I'm not attaching new unit tests as I would like to refactore the Upgraders a bit after this and SQOOP-1254 gets committed.
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorMetadataUpgrader.java
Revision 864426c New Change
[20] 22 lines
[+20]
23
import org.apache.sqoop.connector.spi.MetadataUpgrader;
23
import org.apache.sqoop.connector.spi.MetadataUpgrader;
24
import org.apache.sqoop.model.MConnectionForms;
24
import org.apache.sqoop.model.MConnectionForms;
25
import org.apache.sqoop.model.MForm;
25
import org.apache.sqoop.model.MForm;
26
import org.apache.sqoop.model.MInput;
26
import org.apache.sqoop.model.MInput;
27
import org.apache.sqoop.model.MJobForms;
27
import org.apache.sqoop.model.MJobForms;
28
import org.apache.sqoop.validation.Status;

   
29

    
   
28

   
30
import java.util.HashMap;
29
import java.util.HashMap;
31
import java.util.List;
30
import java.util.List;
32
import java.util.Map;
31
import java.util.Map;
33

    
   
32

   
[+20] [20] 47 lines
core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java
Revision ef00780 New Change
 
core/src/test/java/org/apache/sqoop/framework/TestFrameworkMetadataUpgrader.java
New File
 
  1. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorMetadataUpgrader.java: Loading...
  2. core/src/main/java/org/apache/sqoop/framework/FrameworkMetadataUpgrader.java: Loading...
  3. core/src/test/java/org/apache/sqoop/framework/TestFrameworkMetadataUpgrader.java: Loading...