Review Board 1.7.22


SQOOP-314 Basic export hangs when target database does not support INSERT syntax with multiple rows of values

Review Request #1585 - Created Aug. 18, 2011 and submitted

Bilung Lee
SQOOP-314
Reviewers
Sqoop
aprabhakar, jmhsieh
sqoop-trunk
Basic export job will hang when the target database does not support insert syntax with multiple rows of values, such as INSERT INTO tbl (col1, col2) VALUES(11, 12),(21, 22),(23, 24)

This is because, in close(), AsyncSqlRecordWriter will still wait for AsyncSqlExecThread to finish even when an SQLException is thrown underneath.

The fix is to introduce a new "--batch" option to execute underlying statements in batch mode instead of a single multirow insert statement.

 
Review request changed
Updated (Aug. 19, 2011, 12:49 a.m.)
New patch that incorporates comments.
Ship it!
Posted (Aug. 19, 2011, 6:02 p.m.)
+1 

Can you please rebase the patch and attach it to the Jira? Thanks!
  1. Yes, just did.