Review Board 1.7.22


Patch for DRILL-281

Review Request #15824 - Created Nov. 24, 2013 and submitted

Timothy Chen
DRILL-281
Reviewers
drill-git
jacques
drill-git
Verified refCount is 0 after broadcast, use async SendBatch call while broadcasting.

 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java
Revision b8a7247 New Change
[20] 128 lines
[+20] [+] public T visitHashPartitionSender(HashToRandomExchange op, X value) throws E {
129
  public T visitRangeSender(RangeSender op, X value) throws E {
129
  public T visitRangeSender(RangeSender op, X value) throws E {
130
    return visitSender(op, value);
130
    return visitSender(op, value);
131
  }
131
  }
132

    
   
132

   
133
  @Override
133
  @Override

    
   
134
  public T visitBroadcastSender(BroadcastSender op, X value) throws E {

    
   
135
    return visitSender(op, value);

    
   
136
  }

    
   
137

   

    
   
138
  @Override
134
  public T visitScreen(Screen op, X value) throws E {
139
  public T visitScreen(Screen op, X value) throws E {
135
    return visitStore(op, value);
140
    return visitStore(op, value);
136
  }
141
  }
137

    
   
142

   
138
  @Override
143
  @Override
[+20] [20] 22 lines
exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java
Revision 040a495 New Change
 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastExchange.java
New File
 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastSender.java
New File
 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java
Revision e1fb3ae New Change
 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderCreator.java
New File
 
exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java
New File
 
exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java
Revision e9b56db New Change
 
exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitTunnel.java
Revision 4ce826c New Change
 
exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestBroadcastExchange.java
New File
 
exec/java-exec/src/test/resources/sender/broadcast_exchange.json
New File
 
exec/java-exec/src/test/resources/sender/broadcast_exchange_long_run.json
New File
 
  1. exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/AbstractPhysicalVisitor.java: Loading...
  2. exec/java-exec/src/main/java/org/apache/drill/exec/physical/base/PhysicalVisitor.java: Loading...
  3. exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastExchange.java: Loading...
  4. exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/BroadcastSender.java: Loading...
  5. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ScreenCreator.java: Loading...
  6. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderCreator.java: Loading...
  7. exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/broadcastsender/BroadcastSenderRootExec.java: Loading...
  8. exec/java-exec/src/main/java/org/apache/drill/exec/record/WritableBatch.java: Loading...
  9. exec/java-exec/src/main/java/org/apache/drill/exec/rpc/bit/BitTunnel.java: Loading...
  10. exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestBroadcastExchange.java: Loading...
  11. exec/java-exec/src/test/resources/sender/broadcast_exchange.json: Loading...
  12. exec/java-exec/src/test/resources/sender/broadcast_exchange_long_run.json: Loading...