Patch for DRILL-281
Review Request #15824 - Created Nov. 24, 2013 and submitted
Verified refCount is 0 after broadcast, use async SendBatch call while broadcasting.
Posted (Nov. 26, 2013, 2:39 a.m.)
Have you done some longer testing (minute+) and made sure that you're not detecting any leaks when you run this with a large number of parallelization?
Posted (Nov. 26, 2013, 8:31 p.m.)
Why are you invoking retain() on your buffers? While getting the buffers from the value vector (BaseDataValueVector) calls retain() on the buffer before releasing it so the reference count should be set for the buffers. What am I missing?
Could you please add comments to all the newly added classes giving a short description of their purpose.
Review request changed
Updated (Feb. 19, 2014, 2:14 a.m.)
- changed from pending to submitted