Review Board 1.7.22


Patch for KAFKA-930

Review Request #15711 - Created Nov. 20, 2013 and updated

Sriram Subramanian
KAFKA-930
Reviewers
kafka
kafka
Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk

Conflicts:
	core/src/main/scala/kafka/controller/KafkaController.scala

Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk

Conflicts:
	core/src/main/scala/kafka/controller/KafkaController.scala

Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


some more changes


use zk for auto rebalance


Address code review feedbacks


Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


commit missing code


some more changes


fix merge conflicts


Add auto leader rebalance support


Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk


Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk

Conflicts:
	core/src/main/scala/kafka/admin/AdminUtils.scala
	core/src/main/scala/kafka/admin/TopicCommand.scala

change comments


commit the remaining changes


Move AddPartitions into TopicCommand

 
Total:
29
Open:
13
Resolved:
14
Dropped:
2
Status:
From:
Description From Last Updated Status
Instead of delaying by 5 secs, should we just delay by config.leaderImbalanceCheckIntervalSeconds? Jun Rao Nov. 20, 2013, 6:30 p.m. Open
Could we rename updateZk to sth like isTriggeredByCommandLine? Jun Rao Nov. 20, 2013, 6:30 p.m. Open
I am wondering if this config is really necessary. Wouldn't it be simpler to always do the balancing on all ... Jun Rao Nov. 20, 2013, 6:30 p.m. Open
Another option is to _always_ try and delete the path - although if the znode doesn't exist it will give ... Joel Koshy Nov. 21, 2013, 2:43 a.m. Open
instead of hardcoding this to 5 seconds, how about delaying it by leaderImbalanceCheckIntervalSeconds? Neha Narkhede Dec. 2, 2013, 6:06 p.m. Open
this API is now a little awkward due to the updateZK parameter. Do we really need it? Another way is ... Neha Narkhede Dec. 2, 2013, 6:06 p.m. Open
do we need this config option? It seems that the same could be achieved by setting a very high value ... Neha Narkhede Dec. 2, 2013, 6:06 p.m. Open
This is a config that we may not need in the future once we are sure that the zookeeper callbacks ... Neha Narkhede Dec. 12, 2013, 12:17 a.m. Open
Could we just write this as preferredREplicaForTopicsByBrokers: Map[Int, Map[TopicAndPartition, Seq[Int]] = controllerContext.controllerLock synchronized { ... } Then, we can make ... Jun Rao Dec. 23, 2013, 7:54 p.m. Open
Ditto for topicsNotInPreferredReplica. It seems that the last 5 statements don't need to be inside the controller lock. Jun Rao Dec. 23, 2013, 7:54 p.m. Open
I think we should use liveOrShuttingDownBrokerIds instead. Jun Rao Dec. 23, 2013, 7:54 p.m. Open
Not sure if it's better to do the preferred partition election through ZK watcher. The issue is that the controller ... Jun Rao Dec. 23, 2013, 7:54 p.m. Open
Just checking isTopicQueuedUpForDeletion() is enough. It will always return true until the topic deletion completes. Jun Rao Feb. 24, 2014, 4:14 p.m. Open
Review request changed
Updated (Feb. 24, 2014, 9:59 a.m.)
  • Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    Conflicts:
    	core/src/main/scala/kafka/controller/KafkaController.scala
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    some more changes
    
    
    use zk for auto rebalance
    
    
    Address code review feedbacks
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    commit missing code
    
    
    some more changes
    
    
    fix merge conflicts
    
    
    Add auto leader rebalance support
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    Conflicts:
    	core/src/main/scala/kafka/admin/AdminUtils.scala
    	core/src/main/scala/kafka/admin/TopicCommand.scala
    
    change comments
    
    
    commit the remaining changes
    
    
    Move AddPartitions into TopicCommand

    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    Conflicts:
    	core/src/main/scala/kafka/controller/KafkaController.scala
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    Conflicts:
    	core/src/main/scala/kafka/controller/KafkaController.scala
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    some more changes
    
    
    use zk for auto rebalance
    
    
    Address code review feedbacks
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    commit missing code
    
    
    some more changes
    
    
    fix merge conflicts
    
    
    Add auto leader rebalance support
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    
    Merge branch 'trunk' of http://git-wip-us.apache.org/repos/asf/kafka into trunk
    
    Conflicts:
    	core/src/main/scala/kafka/admin/AdminUtils.scala
    	core/src/main/scala/kafka/admin/TopicCommand.scala
    
    change comments
    
    
    commit the remaining changes
    
    
    Move AddPartitions into TopicCommand
Ship it!
Posted (Feb. 24, 2014, 4:14 p.m.)
Just the following minor comment.
Just checking isTopicQueuedUpForDeletion() is enough. It will always return true until the topic deletion completes.