Review Board 1.7.22


ACCUMULO-1556: Clarify initialization error messages for pre-initialized filesystem

Review Request #15279 - Created Nov. 6, 2013 and submitted

Bill Havanki
1.4.5-SNAPSHOT
ACCUMULO-1556
Reviewers
accumulo
accumulo
The Initialize class now generates clearer error messages if an initialized instance is discovered. The messages vary depending on whether instance.dfs.uri is used.

Note that to facilitate unit testing, the verification logic in Initialize.doInit() was refactored into a checkInit() method.
Ran initialization with patch changes on 1.4.3 cluster under CDH 4.3. Tested successful initialization and correct emission of error messages when instance.dfs.uri was used and was not used. Also, implemented unit tests for altered code.

Diff revision 3

This is not the most recent revision of the diff. The latest diff is revision 4. See what's changed.

1 2 3 4
1 2 3 4

  1. pom.xml: Loading...
  2. src/server/pom.xml: Loading...
  3. src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java: Loading...
  4. src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java: Loading...
pom.xml
Revision 9ed2fdf1c7a1f8831667b27bfaa307fbe2467fe8 New Change
[20] 649 lines
[+20]
650
        <artifactId>junit</artifactId>
650
        <artifactId>junit</artifactId>
651
        <version>4.11</version>
651
        <version>4.11</version>
652
        <scope>test</scope>
652
        <scope>test</scope>
653
      </dependency>
653
      </dependency>
654
      <dependency>
654
      <dependency>

    
   
655
        <groupId>org.easymock</groupId>

    
   
656
        <artifactId>easymock</artifactId>

    
   
657
        <version>3.1</version>

    
   
658
        <scope>test</scope>

    
   
659
      </dependency>

    
   
660
      <dependency>
655
        <groupId>com.google.guava</groupId>
661
        <groupId>com.google.guava</groupId>
656
        <artifactId>guava</artifactId>
662
        <artifactId>guava</artifactId>
657
        <version>14.0.1</version>
663
        <version>14.0.1</version>
658
        <scope>test</scope>
664
        <scope>test</scope>
659
      </dependency>
665
      </dependency>
[+20] [20] 159 lines
src/server/pom.xml
Revision 6421bc69cda5116f9716d30adc3d510baa3bb7d6 New Change
 
src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java
Revision 51576fcc8ff8ffcd65a78bfeaaaf51036360a6bc New Change
 
src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java
New File
 
  1. pom.xml: Loading...
  2. src/server/pom.xml: Loading...
  3. src/server/src/main/java/org/apache/accumulo/server/util/Initialize.java: Loading...
  4. src/server/src/test/java/org/apache/accumulo/server/util/InitializeTest.java: Loading...