Review Board 1.7.22


address Neha's review comments

Review Request #15201 - Created Nov. 4, 2013 and updated

Jun Rao
KAFKA-1117
Reviewers
kafka
kafka
kafka-1117; fix 5


kafka-1117; fix 4


kafka-1117; fix 3


kafka-1117; fix 2


kafka-1117; fix 1


kafka-1117

 

Diff revision 5 (Latest)

1 2 3 4 5
1 2 3 4 5

  1. core/src/main/scala/kafka/api/OffsetResponse.scala: Loading...
  2. core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala: Loading...
core/src/main/scala/kafka/api/OffsetResponse.scala
Revision 08dc3cd3d166efba6b2b43f6e148f636b175affe New Change
[20] 41 lines
[+20]
42
  }
42
  }
43

    
   
43

   
44
}
44
}
45

    
   
45

   
46

    
   
46

   
47
case class PartitionOffsetsResponse(error: Short, offsets: Seq[Long])
47
case class PartitionOffsetsResponse(error: Short, offsets: Seq[Long]) {

    
   
48
  override def toString(): String = {

    
   
49
    new String("error: " + ErrorMapping.exceptionFor(error).getClass.getName + " offsets: " + offsets.mkString)

    
   
50
  }

    
   
51
}
48

    
   
52

   
49

    
   
53

   
50
case class OffsetResponse(override val correlationId: Int,
54
case class OffsetResponse(override val correlationId: Int,
51
                          partitionErrorAndOffsets: Map[TopicAndPartition, PartitionOffsetsResponse])
55
                          partitionErrorAndOffsets: Map[TopicAndPartition, PartitionOffsetsResponse])
52
    extends RequestOrResponse(correlationId = correlationId) {
56
    extends RequestOrResponse(correlationId = correlationId) {
[+20] [20] 42 lines
core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala
New File
 
  1. core/src/main/scala/kafka/api/OffsetResponse.scala: Loading...
  2. core/src/main/scala/kafka/tools/ReplicaVerificationTool.scala: Loading...