Review Board 1.7.22


address Neha's review comments

Review Request #15201 - Created Nov. 4, 2013 and updated

Jun Rao
KAFKA-1117
Reviewers
kafka
kafka
kafka-1117; fix 5


kafka-1117; fix 4


kafka-1117; fix 3


kafka-1117; fix 2


kafka-1117; fix 1


kafka-1117

 
Total:
16
Open:
7
Resolved:
9
Dropped:
0
Status:
From:
Description From Last Updated Status
Default max.message.size is (1MB + header). Default fetch size should be a little larger than 1MB. How about 1.1 MB? Neha Narkhede Nov. 5, 2013, 6:27 p.m. Open
This can throw an exception if the leader doesn't exist Replicas that don't have a leader when this tool is ... Neha Narkhede Nov. 5, 2013, 6:27 p.m. Open
It will be useful to know the fetch offset of the chunk that is undergoing verification. Neha Narkhede Nov. 5, 2013, 6:27 p.m. Open
map{ -> map { Neha Narkhede Nov. 5, 2013, 6:27 p.m. Open
What happens if one replica returns empty message set because it is not caught up and other replicas return some ... Neha Narkhede Nov. 5, 2013, 6:27 p.m. Open
createNewVerificationBarrier here will set the count to 1, and then count it down to 0. So the next round the ... Guozhang Wang Nov. 5, 2013, 10:41 p.m. Open
It seems like the message iterator can have multiple messages, but we verify only the first message per replica? Neha Narkhede Nov. 17, 2013, 5:19 p.m. Open
Review request changed
Updated (Nov. 18, 2013, 5:57 p.m.)
  • kafka-1117; fix 4
    
    
    kafka-1117; fix 3
    
    
    kafka-1117; fix 2
    
    
    kafka-1117; fix 1
    
    
    kafka-1117

    kafka-1117; fix 5
    
    
    kafka-1117; fix 4
    
    
    kafka-1117; fix 3
    
    
    kafka-1117; fix 2
    
    
    kafka-1117; fix 1
    
    
    kafka-1117
  • changed from address all review comments to address Neha's review comments
Ship it!
Posted (Nov. 18, 2013, 7:52 p.m.)
Ship It!