Review Board 1.7.22


Vaibhav Gumashta got review request #15151!

Better error reporting by async threads in HiveServer2

Review Request #15151 - Created Oct. 31, 2013 and updated

Vaibhav Gumashta
trunk
HIVE-5230
Reviewers
hive
cwsteinbach, prasadm, thejas
hive-git
[HIVE-4617|https://issues.apache.org/jira/browse/HIVE-4617] provides support for async execution in HS2. When a background thread gets an error, currently the client can only poll for the operation state and also the error with its stacktrace is logged. However, it will be useful to provide a richer error response like thrift API does with TStatus (which is constructed while building a Thrift response object). 

 

Diff revision 9 (Latest)

1 2 3 4 5 6 7 8 9
1 2 3 4 5 6 7 8 9

  1. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java: Loading...
  2. jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java: Loading...
  3. service/if/TCLIService.thrift: Loading...
  4. service/src/gen/thrift/gen-cpp/TCLIService_types.h: Loading...
  5. service/src/gen/thrift/gen-cpp/TCLIService_types.cpp: Loading...
  6. service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java: Loading...
  7. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java: Loading...
  8. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusResp.java: Loading...
  9. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java: Loading...
  10. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java: Loading...
  11. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java: Loading...
  12. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java: Loading...
  13. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java: Loading...
  14. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java: Loading...
  15. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java: Loading...
  16. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java: Loading...
  17. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java: Loading...
  18. service/src/gen/thrift/gen-py/TCLIService/ttypes.py: Loading...
  19. service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: Loading...
  20. service/src/java/org/apache/hive/service/cli/CLIService.java: Loading...
This diff has been split across 2 pages: 1 2 >
jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java
Revision e420b75 New Change
[20] 133 lines
[+20] [+] public class HiveConnection implements java.sql.Connection {
134
    // add supported protocols
134
    // add supported protocols
135
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V1);
135
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V1);
136
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V2);
136
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V2);
137
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V3);
137
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V3);
138
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V4);
138
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V4);

    
   
139
    supportedProtocols.add(TProtocolVersion.HIVE_CLI_SERVICE_PROTOCOL_V5);
139

    
   
140

   
140
    // open client session
141
    // open client session
141
    openSession();
142
    openSession();
142

    
   
143

   
143
    configureConnection();
144
    configureConnection();
144
  }
145
  }
145

    
   
146

   
146
  private void openTransport() throws SQLException {
147
  private void openTransport() throws SQLException {
147
    transport = isHttpTransportMode() ?
148
    transport = isHttpTransportMode() ? createHttpTransport() : createBinaryTransport();
148
        createHttpTransport() :

   
149
          createBinaryTransport();

   
150
    TProtocol protocol = new TBinaryProtocol(transport);
149
    TProtocol protocol = new TBinaryProtocol(transport);
151
    client = new TCLIService.Client(protocol);
150
    client = new TCLIService.Client(protocol);
152
    try {
151
    try {
153
      transport.open();
152
      transport.open();
154
    } catch (TTransportException e) {
153
    } catch (TTransportException e) {
[+20] [20] 769 lines
jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java
Revision 37975e5 New Change
 
service/if/TCLIService.thrift
Revision 62a9730 New Change
 
service/src/gen/thrift/gen-cpp/TCLIService_types.h
Revision 853bb4c New Change
 
service/src/gen/thrift/gen-cpp/TCLIService_types.cpp
Revision 7ab1310 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java
Revision 1c44789 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java
Revision 497cc01 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusResp.java
Revision b5c3f01 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java
Revision 1cb5147 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java
Revision 8ab8297 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java
Revision 688f790 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java
Revision 8c6c4f0 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java
Revision 0b6772c New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java
Revision db2262d New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java
Revision 81c2f16 New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java
Revision ff5e54d New Change
 
service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java
Revision 251f86a New Change
 
service/src/gen/thrift/gen-py/TCLIService/ttypes.py
Revision 185ea5b New Change
 
service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb
Revision c94acbf New Change
 
service/src/java/org/apache/hive/service/cli/CLIService.java
Revision 8c85386 New Change
 
  1. jdbc/src/java/org/apache/hive/jdbc/HiveConnection.java: Loading...
  2. jdbc/src/java/org/apache/hive/jdbc/HiveStatement.java: Loading...
  3. service/if/TCLIService.thrift: Loading...
  4. service/src/gen/thrift/gen-cpp/TCLIService_types.h: Loading...
  5. service/src/gen/thrift/gen-cpp/TCLIService_types.cpp: Loading...
  6. service/src/gen/thrift/gen-javabean/org/apache/hadoop/hive/service/ThriftHive.java: Loading...
  7. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TColumn.java: Loading...
  8. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetOperationStatusResp.java: Loading...
  9. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TGetTablesReq.java: Loading...
  10. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionReq.java: Loading...
  11. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TOpenSessionResp.java: Loading...
  12. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TProtocolVersion.java: Loading...
  13. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRow.java: Loading...
  14. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TRowSet.java: Loading...
  15. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TStatus.java: Loading...
  16. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTableSchema.java: Loading...
  17. service/src/gen/thrift/gen-javabean/org/apache/hive/service/cli/thrift/TTypeDesc.java: Loading...
  18. service/src/gen/thrift/gen-py/TCLIService/ttypes.py: Loading...
  19. service/src/gen/thrift/gen-rb/t_c_l_i_service_types.rb: Loading...
  20. service/src/java/org/apache/hive/service/cli/CLIService.java: Loading...
This diff has been split across 2 pages: 1 2 >