Review Board 1.7.22


Patch for KAFKA-1107

Review Request #15137 - Created Oct. 31, 2013 and updated

Neha Narkhede
KAFKA-1107
Reviewers
kafka
jkreps
kafka
Remove whitespace changes to LogTest


Removed an unncessary log statement and fixed a few more tests that initially had the Log public API change


Per Jay's suggestion, avoid changing the public API of Log


Avoid printing clean shutdown file log message on every log


KAFKA-1107 Broker unnecessarily recovers all logs when upgrading from 0.8 to 0.8.1; Fix includes modifying Log to avoid recovery if the clean shutdown file exists; LogManager deletes the clean shutdown file after all logs in a log directory have finished loading; If the clean shutdown file does not exist, fall back to 0.8.1 recovery logic

 
Total:
2
Open:
0
Resolved:
2
Dropped:
0
Status:
From:
Description From Last Updated Status
Review request changed
Updated (Oct. 31, 2013, 10:28 p.m.)
  • Removed an unncessary log statement and fixed a few more tests that initially had the Log public API change
    
    
    Per Jay's suggestion, avoid changing the public API of Log
    
    
    Avoid printing clean shutdown file log message on every log
    
    
    KAFKA-1107 Broker unnecessarily recovers all logs when upgrading from 0.8 to 0.8.1; Fix includes modifying Log to avoid recovery if the clean shutdown file exists; LogManager deletes the clean shutdown file after all logs in a log directory have finished loading; If the clean shutdown file does not exist, fall back to 0.8.1 recovery logic

    Remove whitespace changes to LogTest
    
    
    Removed an unncessary log statement and fixed a few more tests that initially had the Log public API change
    
    
    Per Jay's suggestion, avoid changing the public API of Log
    
    
    Avoid printing clean shutdown file log message on every log
    
    
    KAFKA-1107 Broker unnecessarily recovers all logs when upgrading from 0.8 to 0.8.1; Fix includes modifying Log to avoid recovery if the clean shutdown file exists; LogManager deletes the clean shutdown file after all logs in a log directory have finished loading; If the clean shutdown file does not exist, fall back to 0.8.1 recovery logic
Posted (Nov. 1, 2013, 1:03 a.m.)

   

  
probably don't need this statement. 
  1. We need to define recoveryPoint as a var here, but you're right, we don't need to initialize it to 50. Changed it to 0.
Ship it!
Posted (Nov. 1, 2013, 1:03 a.m.)
Ship It!
Ship it!
Posted (Nov. 1, 2013, 3:36 a.m.)
Ship It!
core/src/main/scala/kafka/log/Log.scala (Diff revision 2)
 
 
Can we change to 
val needsRecovery = new File(dir.parentDir, CleanShutdownFile).exists