Review Board 1.7.22


HBASE-4197: Fix Scanner interfaces in HRegion, HRegionServer, and RegionObserver.

Review Request #1496 - Created Aug. 13, 2011 and submitted

Lars Hofhansl
trunk
HBASE-4197
Reviewers
hbase
mingjielai, tedyu
hbase
1. Don't require custom scanners created by coprocessors to be subclasses of HRegion.RegionScanner (see HBASE-4197).
2. Simplify the interfaces for Scanners in HRegion, HRegionServer, and RegionObserver. This avoids a bunch instanceof checks and casts to HRegion.RegionScanner.

(Sorry HBase-git would not accept my patch)
Manual test attached to the bug.
Review request changed
Updated (Aug. 15, 2011, 9:21 p.m.)
  • 1. Don't require custom scanners created by conprocessors to be subclasses of HRegion.RegionScanner (see HBASE-4197).
    2. Simplify the interfaces for Scanners in HRegion, HRegionServer, and RegionObserver. This avoids a bunch instanceof checks and casts to HRegion.RegionScanner.
    
    (Sorry HBase-git would not accept my patch)

    1. Don't require custom scanners created by coprocessors to be subclasses of HRegion.RegionScanner (see HBASE-4197).
    2. Simplify the interfaces for Scanners in HRegion, HRegionServer, and RegionObserver. This avoids a bunch instanceof checks and casts to HRegion.RegionScanner.
    
    (Sorry HBase-git would not accept my patch)
  • changed from Streamline use of Scanner interfaces in HRegion, HRegionServer, and RegionObserver. to HBASE-4197: Fix Scanner interfaces in HRegion, HRegionServer, and RegionObserver.
Posted (Aug. 15, 2011, 9:46 p.m.)
I saw you have a test case posted to jira as attachment -- ScannerTest.java. Are you gonna make it part of this patch? 

The patch looks good to me. 
This line has > 80 characters. Can you wrap it? 
Ship it!
Posted (Aug. 15, 2011, 10:02 p.m.)