Review Board 1.7.22


Pushdown join conditions

Review Request #14953 - Created Oct. 25, 2013 and submitted

Harish Butani
hive-5556
Reviewers
hive
ashutoshc, vikram.dixit
hive-git
Step 1 to support Alternate Join Syntax: HIVE-5555

This patch also contains fixes to merging of QBJoinTrees
ran all join .q files
added join_cond_pushdown_1.q, join_cond_pushdown_2.q .q tests
added TestQBJoinTreeApplyPredicate unit test to test pushdown functionality
ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java
Revision 9c8cac1 New Change
[20] 108 lines
[+20] [+] public String getLeftAlias() {
109
   *
109
   *
110
   * @param leftAlias
110
   * @param leftAlias
111
   *          String
111
   *          String
112
   */
112
   */
113
  public void setLeftAlias(String leftAlias) {
113
  public void setLeftAlias(String leftAlias) {

    
   
114
    if ( this.leftAlias != null && !this.leftAlias.equals(leftAlias) ) {

    
   
115
      this.leftAlias = null;

    
   
116
    } else {
114
    this.leftAlias = leftAlias;
117
      this.leftAlias = leftAlias;
115
  }
118
    }

    
   
119
  }
116

    
   
120

   
117
  public String[] getRightAliases() {
121
  public String[] getRightAliases() {
118
    return rightAliases;
122
    return rightAliases;
119
  }
123
  }
120

    
   
124

   
[+20] [20] 246 lines
ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java
Revision cf0c895 New Change
 
ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java
New File
 
ql/src/test/queries/clientpositive/join_cond_pushdown_1.q
New File
 
ql/src/test/queries/clientpositive/join_cond_pushdown_2.q
New File
 
ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out
Revision 865627b New Change
 
ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out
New File
 
ql/src/test/results/clientpositive/join_cond_pushdown_2.q.out
New File
 
  1. ql/src/java/org/apache/hadoop/hive/ql/parse/QBJoinTree.java: Loading...
  2. ql/src/java/org/apache/hadoop/hive/ql/parse/SemanticAnalyzer.java: Loading...
  3. ql/src/test/org/apache/hadoop/hive/ql/parse/TestQBJoinTreeApplyPredicate.java: Loading...
  4. ql/src/test/queries/clientpositive/join_cond_pushdown_1.q: Loading...
  5. ql/src/test/queries/clientpositive/join_cond_pushdown_2.q: Loading...
  6. ql/src/test/results/clientpositive/auto_sortmerge_join_12.q.out: Loading...
  7. ql/src/test/results/clientpositive/join_cond_pushdown_1.q.out: Loading...
  8. ql/src/test/results/clientpositive/join_cond_pushdown_2.q.out: Loading...