Review Board 1.7.22


Patch for KAFKA-1086

Review Request #14638 - Created Oct. 14, 2013 and updated

Neha Narkhede
KAFKA-1086
Reviewers
kafka
kafka
Incorporated Joel's review comments


Minor change to patch review tool


Changed command line parameter partition->partitions


Improved GetOffsetShell to query metadata automatically, add batch offset request for all partitions of a topic and improve usability

 

Diff revision 2 (Latest)

1 2
1 2

  1. kafka-patch-review.py: Loading...
  2. core/src/main/scala/kafka/tools/GetOffsetShell.scala: Loading...
kafka-patch-review.py
Revision f1d5192057755e9cd24861c1f995638e2eada1d1 New Change
[20] 87 lines
[+20] [+] def main():
88
  jira.add_attachment(issue,attachment)
88
  jira.add_attachment(issue,attachment)
89
  attachment.close()
89
  attachment.close()
90

    
   
90

   
91
  comment="Created reviewboard " 
91
  comment="Created reviewboard " 
92
  if not opt.reviewboard:
92
  if not opt.reviewboard:
93
    print 'Created a new reviewboard ',rb_url
93
    print 'Created a new reviewboard ',rb_url,' against branch: ',opt.branch
94
  else:
94
  else:
95
    print 'Updated reviewboard',opt.reviewboard
95
    print 'Updated reviewboard',opt.reviewboard
96
    comment="Updated reviewboard "
96
    comment="Updated reviewboard "
97

    
   
97

   
98
  comment = comment + rb_url 
98
  comment = comment + rb_url 
99
  jira.add_comment(opt.jira, comment)
99
  jira.add_comment(opt.jira, comment)
100

    
   
100

   
101
if __name__ == '__main__':
101
if __name__ == '__main__':
102
  sys.exit(main())
102
  sys.exit(main())
103

    
   
103

   
core/src/main/scala/kafka/tools/GetOffsetShell.scala
Revision 2b9438ae3a4da2c7f97e05fb26bc179fe48f137d New Change
 
  1. kafka-patch-review.py: Loading...
  2. core/src/main/scala/kafka/tools/GetOffsetShell.scala: Loading...