Review Board 1.7.22


PIG-3480 TFile-based tmpfile compression crashes in some cases

Review Request #14552 - Created Oct. 9, 2013 and updated

Aniket Mokashi
trunk
PIG-3480
Reviewers
pig
cheolsoo, dvryaboy, julien, rohini
pig
- Added a new parameter to make SequenceFileInterStorage optional.
- Added tests
- Refactored apis

 
Total:
12
Open:
0
Resolved:
10
Dropped:
2
Status:
From:
Description From Last Updated Status
Review request changed
Updated (Oct. 12, 2013, 12:44 a.m.)
Posted (Oct. 13, 2013, 11:40 a.m.)
Just one last comment. Otherwise it looks good to me.
Thanks Aniket!
trunk/src/org/apache/pig/impl/util/Utils.java (Diff revision 5)
 
 
 
 
now it should be:
} else if (TEMPFILE_STORAGE.TFILE.lowerName().equals(tmpFileCompressionStorage)) {
  return TEMPFILE_STORAGE.TFILE;
} else {
  throw new ...Exception("unsupported format " + tmpFileCompressionStorage + ". Should be one of " + Arrays.toString(TEMPFILE_STORAGE.values()));
}
  1. Thanks for catching that. I incorporated this change.