Review Board 1.7.22


SQOOP-1212 Do not print usage on wrong command line

Review Request #14521 - Created Oct. 7, 2013 and updated

Jarek Cecho
SQOOP-1212
Reviewers
Sqoop
sqoop-trunk
I've removed the code responsible for printing out the usage on incorrect command line. This might be seen as backward incompatible change to some extent, however I believe that no external process should be depending on a usage printed out when incorrect command line is entered and therefore that this change should be fine. Please do not hesitate and let me know if there are any concerns about that!
1) Incomplete command line
[root@bousa-trunk ~]# sqoop import --table x
13/10/07 12:09:23 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
Error: Required argument --connect is missing.
Try --help for usage instructions.
[root@bousa-trunk ~]#

2) Unknown command line argument
[root@bousa-trunk ~]# sqoop import --table x --xxx
13/10/07 12:09:36 INFO sqoop.Sqoop: Running Sqoop version: 1.4.5-SNAPSHOT
13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Error parsing arguments for import:
13/10/07 12:09:36 ERROR tool.BaseSqoopTool: Unrecognized argument: --xxx

Try --help for usage instructions.
Ship it!
Posted (Feb. 3, 2014, 6:38 p.m.)
Perfect. Never did like unnecessary usage info!