Review Board 1.7.22


incorporating review feedback

Review Request #14496 - Created Oct. 4, 2013 and updated

Jun Rao
KAFKA-1073
Reviewers
kafka
kafka
kafka-1017; incorporating review feedback


kafka-1017

 
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (Oct. 5, 2013, 6:02 p.m.)
  • kafka-1017

    kafka-1017; incorporating review feedback
    
    
    kafka-1017
  • changed from Patch for KAFKA-1073 to incorporating review feedback
Posted (Oct. 6, 2013, 8 p.m.)

   

  
Instead of asking the user to store the output of a dryrun into a JSON file, should the tool compute the dryrun output and use it to perform validation ?
  1. That would be a better experience and since only one reassignment operation can ever be in progress, this could've been possible by reading the reassignment zookeeper path. However, we can't reliably do that right now since we overwrite that path when reassignment is completed. Ideally, if we can avoid rewriting that and report progress for the reassignment operation, it would be a better tooling experience. Probably we can fix that in a separate JIRA?
  2. Another possible way is to not returning until the topic partitions zk path has reflected the change, i.e. the checkIfReassignmentSucceeded has passed. 
Ship it!
Posted (Oct. 6, 2013, 8:13 p.m.)
Ship It!