Review Board 1.7.22


HIVE-5382

Review Request #14430 - Created Oct. 1, 2013 and updated

Hari Sankar Sivarama Subramaniyan
HIVE-5382
Reviewers
hive
ashutoshc, haglein, thejas
hive
Allow casting of exponential notation whenever possible. 
Limitations:
1. The exponential part will be limited between MIN_VAL and MAX_VAL of the data types even if the final result might be within the boundaries.
2. Allow loss-less transformation using BigDecimal and Double types.
Ran basic tests on cast_to_int.
Review request changed
Updated (Oct. 2, 2013, 3:39 a.m.)
Posted (Oct. 2, 2013, 11:09 p.m.)

   

  
it'd be good to do some testing in non radix 10, right?
BigDecimal is really slow and I'm not sure why you need this here...
depending on radix characters don't have to be between '0' - '9'
i believe e is actually a valid character for some radixes. not sure how that should be handled... maybe allow exp notation only in radix 10?
do we have to do this in double? should be able to keep in long. that way we dont' have to worry about double weirdness (loss of precision, NaN)
i think we're ending up with a lot of duplicated code now between long/int. i think if we go this route we need to combine these. (I think performance is the only reason why we have this twice).
not sure why double will be loss less.