Review Board 1.7.22


Allow Multiple Versions of a Row When Importing Using Sqoop

Review Request #14377 - Created Sept. 27, 2013 and updated

William Watson
Reviewers
Sqoop
sqoop-trunk
See https://issues.apache.org/jira/browse/SQOOP-611

 
Review request changed
Updated (Oct. 7, 2013, 2:36 p.m.)
  • changed from discarded to pending
  • 
    	  

    See https://issues.apache.org/jira/browse/SQOOP-611
  • changed from to Allow Multiple Versions of a Row When Importing Using Sqoop
Posted (Oct. 9, 2013, 10:53 p.m.)
Hi William, 
thank you very much for working on this functionality. It seems that the patch is not currently compilable, would you mind taking a look? I do have couple of random nits below:
src/docs/user/hbase-args.txt (Diff revision 1)
 
 
 
Can we also provide paragraph about the parameter in the file hbase.txt describing details for this parameter (usage, ...)?
src/docs/user/hbase-args.txt (Diff revision 1)
 
 
Nit: Trailing whitespace
com.cloudera classes are provided for backward compatibility and should not be changed any more.
com.cloudera classes are provided for backward compatibility and should not be changed any more.
Super nit: Please use space between the comment and word "Column".
Can we also verify that such column indeed exists? We should make sure that user won't try to pass column name that is not being imported.
src/java/org/apache/sqoop/mapreduce/HBaseImportMapper.java (Diff revision 1)
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
 
This change do not seem to be relevant for the patch. If that is indeed the case, can we make a separate JIRA for it? Having one patch with multiple logical changes makes hard to use tools such as "git blame".
The exception here seems to be breaking the usual flow in parsing the arguments, is it intentional?
Jarcec