Review Board 1.7.22


Patch for KAFKA-1053

Review Request #14091 - Created Sept. 11, 2013 and updated

Neha Narkhede
KAFKA-1053
Reviewers
kafka
kafka
Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting


Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting


1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch


Use underscore to separate jira, date and time in patch name


Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp


Included Guozhang's suggestion about making --version mandatory if --rb is specified


Included Guozhang's suggestion about making --version mandatory if --rb is specified


Attaching file using jira-python package


Changed the script to use the jira-python package, part 2


Changed the script to use the jira-python package


Changed the creating a reviewboard comment as suggested by Tejas


Included Tejas's comments


Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA


publish automatically


Patch review tool

 

Diff revision 14 (Latest)

1 2 3 4 5 6 7 8 9 10 11 12 13 14
1 2 3 4 5 6 7 8 9 10 11 12 13 14

  1. .reviewboardrc: Loading...
  2. kafka-patch-review.py: Loading...
.reviewboardrc
New File

    
   
1
REPOSITORY = 'git://git.apache.org/kafka.git'

    
   
2
TARGET_GROUPS = 'kafka'

    
   
3
GUESS_FIELDS = True	
kafka-patch-review.py
New File
 
  1. .reviewboardrc: Loading...
  2. kafka-patch-review.py: Loading...