Review Board 1.7.22


Patch for KAFKA-1053

Review Request #14091 - Created Sept. 11, 2013 and updated

Neha Narkhede
KAFKA-1053
Reviewers
kafka
kafka
Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting


Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting


1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch


Use underscore to separate jira, date and time in patch name


Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp


Included Guozhang's suggestion about making --version mandatory if --rb is specified


Included Guozhang's suggestion about making --version mandatory if --rb is specified


Attaching file using jira-python package


Changed the script to use the jira-python package, part 2


Changed the script to use the jira-python package


Changed the creating a reviewboard comment as suggested by Tejas


Included Tejas's comments


Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA


publish automatically


Patch review tool

 
Total:
5
Open:
0
Resolved:
2
Dropped:
3
Status:
From:
Review request changed
Updated (Sept. 16, 2013, 9:40 p.m.)
  • 1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch
    
    
    Use underscore to separate jira, date and time in patch name
    
    
    Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
    
    
    Included Guozhang's suggestion about making --version mandatory if --rb is specified
    
    
    Included Guozhang's suggestion about making --version mandatory if --rb is specified
    
    
    Attaching file using jira-python package
    
    
    Changed the script to use the jira-python package, part 2
    
    
    Changed the script to use the jira-python package
    
    
    Changed the creating a reviewboard comment as suggested by Tejas
    
    
    Included Tejas's comments
    
    
    Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
    
    
    publish automatically
    
    
    Patch review tool

    Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting
    
    
    Addressing issues that Swapnil ran into 1) Passing the --debug option to post-review to get meaningful debug messages from post-review in case it fails 2) Adding git remote update in the script since that is a common reason for the post-review failing 3) Improved error message reporting
    
    
    1) Removed reference to JIRA_CMDLINE_HOME as it is not required anymore 2) Improved error handling to handle the case if the patch is empty 3) Prevent uploading patch and updating/creating reviewboard if patch is empty or diff is not checked into local branch
    
    
    Use underscore to separate jira, date and time in patch name
    
    
    Addressed Swapnil's review comments - 1) Closed the file handle for the git command 2) Removed the --version command line option and automated version to be the timestamp
    
    
    Included Guozhang's suggestion about making --version mandatory if --rb is specified
    
    
    Included Guozhang's suggestion about making --version mandatory if --rb is specified
    
    
    Attaching file using jira-python package
    
    
    Changed the script to use the jira-python package, part 2
    
    
    Changed the script to use the jira-python package
    
    
    Changed the creating a reviewboard comment as suggested by Tejas
    
    
    Included Tejas's comments
    
    
    Changed the post-review tool to publish the rb automatically. Updated the tool to add a link to the rb in the JIRA
    
    
    publish automatically
    
    
    Patch review tool