Sqoop-1182: Compression option for import
Review Request #13839 - Created Aug. 27, 2013 and submitted
Exposing compression options for Sqoop2
Added unit tests. Manually tested.
|The enum seems to be as a great fit for the choice of compression format, but it might be tricky ...||Jarek Cecho||Sept. 2, 2013, 2:10 p.m.||Open|
Posted (Sept. 2, 2013, 2:10 p.m.)
The enum seems to be as a great fit for the choice of compression format, but it might be tricky in following two situations: * Not all the predefined compression codecs might be available on the Hadoop cluster. * Some compression codecs available on the Hadoop cluster might not be available in the predefined list. I think that technically the ideal solution would be to include String input that would accept classname for the codec - this way user would have complete power of what he wants to use. On the other hand such approach is not much user friendly. What about merging this and the original idea? We can also put inside the enum value "OTHER" and let user specify custom class? We can always verify if the custom class is available in the Validator.
Posted (Sept. 4, 2013, 8:13 p.m.)
Looks good. Regarding the support for custom compression format, I think we can track it as part of a separate JIRA. Do you agree Jarcec? Thanks Venkat
Review request changed
Updated (Sept. 9, 2013, 1:02 p.m.)
- changed from pending to submitted