Review Board 1.7.22


SQOOP-1183 Sqoop2: Add getConnector(String) to the client API

Review Request #13794 - Created Aug. 24, 2013 and updated

Jarek Cecho
SQOOP-1183
Reviewers
Sqoop
sqoop-sqoop2
Added proposed methods getConnector(String) and newConnection(Strong).
Added unit test to verify the caching logic for the new methods and altered integration tests to use this new method.
client/src/main/java/org/apache/sqoop/client/ClientError.java
Revision aafb5b0891df23726b14c730f570f745990cb8e7 New Change
[20] 27 lines
[+20]
28
  CLIENT_0001("Server has returned exception"),
28
  CLIENT_0001("Server has returned exception"),
29

    
   
29

   
30
  /** Polling time of submission status cannot be negative */
30
  /** Polling time of submission status cannot be negative */
31
  CLIENT_0002("Polling time of submission status cannot be negative"),
31
  CLIENT_0002("Polling time of submission status cannot be negative"),
32

    
   
32

   

    
   
33
  /** Given connector is not known to the server **/

    
   
34
  CLIENT_0003("Connector do not exists"),
33
  ;
35
  ;
34

    
   
36

   
35
  private final String message;
37
  private final String message;
36

    
   
38

   
37
  private ClientError(String message) {
39
  private ClientError(String message) {
[+20] [20] 11 lines
client/src/main/java/org/apache/sqoop/client/SqoopClient.java
Revision f9e7ddd32a841a0a79488b48e278ae4cee7897e5 New Change
 
client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java
Revision 3e0544a00b93bbf30bb723a2b070caa5256618a1 New Change
 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java
Revision ee8b97bd1f16b110432569b3ad9d5f353e58cddd New Change
 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java
Revision b500828de0ff206b36c4cbe370a5f1737e6e0a2c New Change
 
test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/imports/PartitionerTest.java
Revision 50fce74dbf707581458f320b25eb9c991be43582 New Change
 
  1. client/src/main/java/org/apache/sqoop/client/ClientError.java: Loading...
  2. client/src/main/java/org/apache/sqoop/client/SqoopClient.java: Loading...
  3. client/src/test/java/org/apache/sqoop/client/TestSqoopClient.java: Loading...
  4. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableExportTest.java: Loading...
  5. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/TableImportTest.java: Loading...
  6. test/src/test/java/org/apache/sqoop/integration/connector/jdbc/generic/imports/PartitionerTest.java: Loading...