Review Board 1.7.22


SQOOP-1120 Sqoop2: Support for PostgreSQL database for hosting the metadata repository

Review Request #13686 - Created Aug. 20, 2013 and updated

Mengwei Ding
SQOOP-1120
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit 1eef61e815dfaf49b031fdf6ade55d1bcc523b01
Author: Mengwei Ding <mengwei.ding@cloudera.com>
Date:   Tue Jul 9 13:41:58 2013 -0700

    SQOOP-1120 Sqoop2: Support for PostgreSQL database for hosting the metadata repository

:100755 100755 bb01016... 56f114c... M	dist/src/main/server/conf/sqoop.properties
:100644 100644 e3345c4... 67dc3fa... M	repository/pom.xml
:000000 100644 0000000... 4ba807a... A	repository/repository-postgres/pom.xml
:000000 100644 0000000... 20ea7a5... A	repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java
:000000 100644 0000000... a01aa73... A	repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java
:000000 100644 0000000... a05aa5f... A	repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java
:000000 100644 0000000... 833bdb6... A	repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java
:000000 100644 0000000... fdce884... A	repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java
:000000 100644 0000000... 12b4c2b... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java
:000000 100644 0000000... 8ca5b69... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java
:000000 100644 0000000... 963bb42... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java
:000000 100644 0000000... 2e3c49b... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java
:000000 100644 0000000... 16ad023... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java
:000000 100644 0000000... c59c83a... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java
:000000 100644 0000000... 03cf6b2... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java
:000000 100644 0000000... 91e7551... A	repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java
:000000 100644 0000000... 44ffced... A	repository/repository-postgres/src/test/resources/log4j.properties
:100644 100644 a07ecf4... df8cc2f... M	server/pom.xml
Pass the integration test for postgreSQL on my local machine. Here in the code, I exclude the postgres integration test.

Diff revision 1 (Latest)

  1. dist/src/main/server/conf/sqoop.properties: Loading...
  2. repository/pom.xml: Loading...
  3. repository/repository-postgres/pom.xml: Loading...
  4. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java: Loading...
  5. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java: Loading...
  6. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java: Loading...
  7. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java: Loading...
  8. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java: Loading...
  9. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java: Loading...
  10. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java: Loading...
  11. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java: Loading...
  12. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java: Loading...
  13. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java: Loading...
  14. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java: Loading...
  15. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java: Loading...
  16. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java: Loading...
  17. repository/repository-postgres/src/test/resources/log4j.properties: Loading...
  18. server/pom.xml: Loading...
dist/src/main/server/conf/sqoop.properties
Revision bb01016 New Change
[20] 80 lines
[+20]
81

    
   
81

   
82
# Repository provider
82
# Repository provider
83
org.apache.sqoop.repository.provider=org.apache.sqoop.repository.JdbcRepositoryProvider
83
org.apache.sqoop.repository.provider=org.apache.sqoop.repository.JdbcRepositoryProvider
84
org.apache.sqoop.repository.schema.immutable=false
84
org.apache.sqoop.repository.schema.immutable=false
85

    
   
85

   
86
# JDBC repository provider configuration
86
# JDBC repository provider configuration for Apache Derby
87
org.apache.sqoop.repository.jdbc.handler=org.apache.sqoop.repository.derby.DerbyRepositoryHandler
87
org.apache.sqoop.repository.jdbc.handler=org.apache.sqoop.repository.derby.DerbyRepositoryHandler
88
org.apache.sqoop.repository.jdbc.transaction.isolation=READ_COMMITTED
88
org.apache.sqoop.repository.jdbc.transaction.isolation=READ_COMMITTED
89
org.apache.sqoop.repository.jdbc.maximum.connections=10
89
org.apache.sqoop.repository.jdbc.maximum.connections=10
90
org.apache.sqoop.repository.jdbc.url=jdbc:derby:@BASEDIR@/repository/db;create=true
90
org.apache.sqoop.repository.jdbc.url=jdbc:derby:@BASEDIR@/repository/db;create=true
91
org.apache.sqoop.repository.jdbc.driver=org.apache.derby.jdbc.EmbeddedDriver
91
org.apache.sqoop.repository.jdbc.driver=org.apache.derby.jdbc.EmbeddedDriver
92
org.apache.sqoop.repository.jdbc.user=sa
92
org.apache.sqoop.repository.jdbc.user=sa
93
org.apache.sqoop.repository.jdbc.password=
93
org.apache.sqoop.repository.jdbc.password=
94

    
   
94

   

    
   
95
# JDBC repository provider configuration for PostgreSQL

    
   
96
# org.apache.sqoop.repository.jdbc.handler=org.apache.sqoop.repository.postgres.PostgresRepositoryHandler

    
   
97
# org.apache.sqoop.repository.jdbc.transaction.isolation=READ_COMMITTED

    
   
98
# org.apache.sqoop.repository.jdbc.maximum.connections=10

    
   
99
# org.apache.sqoop.repository.jdbc.url=jdbc:postgresql://localhost/sqoop

    
   
100
# org.apache.sqoop.repository.jdbc.driver=org.postgresql.Driver

    
   
101
# org.apache.sqoop.repository.jdbc.user=sa

    
   
102
# org.apache.sqoop.repository.jdbc.password=

    
   
103

   
95
# System properties for embedded Derby configuration
104
# System properties for embedded Derby configuration
96
org.apache.sqoop.repository.sysprop.derby.stream.error.file=@LOGDIR@/derbyrepo.log
105
# org.apache.sqoop.repository.sysprop.derby.stream.error.file=@LOGDIR@/derbyrepo.log

    
   
106

   

    
   
107
org.apache.sqoop.repository.sysprop.postgres.stream.error.file=@LOGDIR@/postgresrepo.log
97

    
   
108

   
98
#
109
#
99
# Connector configuration
110
# Connector configuration
100
#
111
#
101
org.apache.sqoop.connector.autoupgrade=false
112
org.apache.sqoop.connector.autoupgrade=false
[+20] [20] 36 lines
repository/pom.xml
Revision e3345c4 New Change
 
repository/repository-postgres/pom.xml
New File
 
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java
New File
 
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java
New File
 
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java
New File
 
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java
New File
 
repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java
New File
 
repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java
New File
 
repository/repository-postgres/src/test/resources/log4j.properties
New File
 
server/pom.xml
Revision a07ecf4 New Change
 
  1. dist/src/main/server/conf/sqoop.properties: Loading...
  2. repository/pom.xml: Loading...
  3. repository/repository-postgres/pom.xml: Loading...
  4. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoConstants.java: Loading...
  5. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepoError.java: Loading...
  6. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresRepositoryHandler.java: Loading...
  7. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaConstants.java: Loading...
  8. repository/repository-postgres/src/main/java/org/apache/sqoop/repository/postgres/PostgresSchemaQuery.java: Loading...
  9. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/PostgresTestCase.java: Loading...
  10. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectionHandling.java: Loading...
  11. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestConnectorHandling.java: Loading...
  12. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestFrameworkHandling.java: Loading...
  13. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInputTypes.java: Loading...
  14. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestInternals.java: Loading...
  15. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestJobHandling.java: Loading...
  16. repository/repository-postgres/src/test/java/org/apache/sqoop/repository/postgres/TestSubmissionHandling.java: Loading...
  17. repository/repository-postgres/src/test/resources/log4j.properties: Loading...
  18. server/pom.xml: Loading...