Review Board 1.7.22


PIG-3414 Utils.getSchemaFromString() silently returns a wrong result when a comma is missing in the schema definition

Review Request #13551 - Created Aug. 14, 2013 and submitted

Cheolsoo Park
PIG-3414
Reviewers
pig
pig-git
I updated the schema parsing grammar, so an invalid schema string throws a parser exception rather than silently returns partial schema.

While running the unit tests, I found and fixed bugs in the following unit tests:
TestSchema
TestSchemaTuple
TestPOCast
Added a new test case to TestSchema.

All the unit tests pass.
Review request changed
Updated (Nov. 3, 2013, 5:33 p.m.)
  • changed from pending to submitted