[PIG-3204] Reduce the number of getSchema calls during script parsing
Review Request #13535 - Created Aug. 13, 2013 and submitted
Change parsing from line by line to whole script at once.
New unit tests added to track the number of times a line is parsed. TestGrunt and TestShortcuts test failures fixed.
Posted (Aug. 14, 2013, 2:13 a.m.)
Overall looks good. I have few minor comments.
I believe we shouldn't remove xargs. It was added by PIG-3099 to avoid some race condition.
This is a bit confusing to me. 10 - 4 + 6 = 12, but numTimesInitiated is set to 10. _testSkipParseInRegisterForBatch(false, 10, 4);
If I understand correctly, this is equivalent to calling the followings: GruntParser grunt = new GruntParser(in); grunt.setInteractive(false); grunt.setParams(pigServer); grunt.parseStopOnError(false); //batch Can you explicitly call them, so it will be easier to identify the difference when skipParseInRegisterForBatch is on and off?
Review request changed
Updated (Dec. 3, 2013, 8:51 p.m.)
- changed from pending to submitted