Review Board 1.7.22


JsonRecordReader changes and working e2e

Review Request #13489 - Created Aug. 12, 2013 and submitted

Timothy Chen
master
Reviewers
drill-git
jacques
drill-git
- Added JsonScanBatch and POP
- Added Repeated support for JsonRecordReader
- Support Late field type binding
- JsonRecordReader working e2e! 

 

Diff revision 1 (Latest)

  1. sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/SchemaPath.java: Loading...
  2. sandbox/prototype/common/src/main/java/org/apache/drill/common/types/Types.java: Loading...
  3. sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java: Loading...
  4. sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/RepeatedValueVectors.java: Loading...
  5. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanBatchCreator.java: Loading...
  6. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanPOP.java: Loading...
  7. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java: Loading...
  8. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/DiffSchema.java: Loading...
  9. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/Field.java: Loading...
  10. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/json/jackson/JacksonHelper.java: Loading...
  11. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/JSONRecordReader.java: Loading...
  12. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java: Loading...
  13. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java: Loading...
  14. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/FixedWidthVector.java: Loading...
  15. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java: Loading...
  16. sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFragmentRun.java: Loading...
  17. sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/store/JSONRecordReaderTest.java: Loading...
  18. sandbox/prototype/exec/java-exec/src/test/resources/physical_json_scan_test1.json: Loading...
  19. sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_4.json: Loading...
  20. sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_5.json: Loading...
sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/SchemaPath.java
Revision 19d1069 New Change
[20] 39 lines
[+20] [+] public class SchemaPath extends LogicalExpressionBase {
40
      + "'?\n" + "(?:\\[\\d+\\])?\n" + ")\n" + "[\\+\\-\\!\\]\\}]?\n" +
40
      + "'?\n" + "(?:\\[\\d+\\])?\n" + ")\n" + "[\\+\\-\\!\\]\\}]?\n" +
41

    
   
41

   
42
      ")*$";
42
      ")*$";
43

    
   
43

   
44
  // reads well in RegexBuddy
44
  // reads well in RegexBuddy
45
  private static final String SEGMENT_REGEX = "(?:\n" + "(\\[\\d+\\])\n" + "|\n" + "'?\n"
45
  private static final String SEGMENT_REGEX = "(?:\n" + "\\[(\\d+)\\]\n" + "|\n" + "'?\n"
46
      + "([^\\.\\[\\+\\-\\!\\]\\}]+)  # identifier\n" + "'?\n" + ")\n"
46
      + "([^\\.\\[\\+\\-\\!\\]\\}]+)  # identifier\n" + "'?\n" + ")\n"
47
      + "([\\+\\-\\!\\]\\}]?)         # collision type";
47
      + "([\\+\\-\\!\\]\\}]?)         # collision type";
48
  private static final int GROUP_INDEX = 1;
48
  private static final int GROUP_INDEX = 1;
49
  private static final int GROUP_PATH_SEGMENT = 2;
49
  private static final int GROUP_PATH_SEGMENT = 2;
50
  private static final int GROUP_COLLISION = 3;
50
  private static final int GROUP_COLLISION = 3;
[+20] [20] 89 lines
sandbox/prototype/common/src/main/java/org/apache/drill/common/types/Types.java
Revision e81bc89 New Change
 
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java
Revision ca222df New Change
 
sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/RepeatedValueVectors.java
Revision 1afe84b New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanBatchCreator.java
New File
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanPOP.java
New File
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java
Revision c31e9e4 New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/DiffSchema.java
Revision b654a92 New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/Field.java
Revision 85bbdf3 New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/json/jackson/JacksonHelper.java
Revision 0e2c052 New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/JSONRecordReader.java
Revision f72b519 New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java
Revision d594b9e New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java
Revision 69c17f4 New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/FixedWidthVector.java
Revision 17e072b New Change
 
sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java
New File
 
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFragmentRun.java
Revision e21289c New Change
 
sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/store/JSONRecordReaderTest.java
Revision 0ebb529 New Change
 
sandbox/prototype/exec/java-exec/src/test/resources/physical_json_scan_test1.json
New File
 
sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_4.json
Revision 0fb3202 New Change
 
sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_5.json
Revision ae1aaf2 New Change
 
  1. sandbox/prototype/common/src/main/java/org/apache/drill/common/expression/SchemaPath.java: Loading...
  2. sandbox/prototype/common/src/main/java/org/apache/drill/common/types/Types.java: Loading...
  3. sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/NullableValueVectors.java: Loading...
  4. sandbox/prototype/exec/java-exec/src/main/codegen/ValueVectors/templates/RepeatedValueVectors.java: Loading...
  5. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanBatchCreator.java: Loading...
  6. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/config/JSONScanPOP.java: Loading...
  7. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/physical/impl/ImplCreator.java: Loading...
  8. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/DiffSchema.java: Loading...
  9. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/Field.java: Loading...
  10. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/schema/json/jackson/JacksonHelper.java: Loading...
  11. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/JSONRecordReader.java: Loading...
  12. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/store/VectorHolder.java: Loading...
  13. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/AllocationHelper.java: Loading...
  14. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/FixedWidthVector.java: Loading...
  15. sandbox/prototype/exec/java-exec/src/main/java/org/apache/drill/exec/vector/RepeatedMutator.java: Loading...
  16. sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/physical/impl/TestSimpleFragmentRun.java: Loading...
  17. sandbox/prototype/exec/java-exec/src/test/java/org/apache/drill/exec/store/JSONRecordReaderTest.java: Loading...
  18. sandbox/prototype/exec/java-exec/src/test/resources/physical_json_scan_test1.json: Loading...
  19. sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_4.json: Loading...
  20. sandbox/prototype/exec/java-exec/src/test/resources/scan_json_test_5.json: Loading...