Review Board 1.7.22


JsonRecordReader changes and working e2e

Review Request #13489 - Created Aug. 12, 2013 and submitted

Timothy Chen
master
Reviewers
drill-git
jacques
drill-git
- Added JsonScanBatch and POP
- Added Repeated support for JsonRecordReader
- Support Late field type binding
- JsonRecordReader working e2e! 

 
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Description From Last Updated Status
nit: could this just be called hasChanged()? Ben Becker Aug. 13, 2013, 7:11 a.m. Open
Review request changed
Updated (Aug. 24, 2013, 9:31 a.m.)
  • changed from pending to submitted
Posted (Aug. 24, 2013, 9:31 a.m.)

   

  
It's actually a valid flow that the token will attempt to create a value vector, but I don't allow that. I allow it to create a field since I want to track the time it was first encountered.
The count is just keeping count the number of values added.

I would love so if I don't need to keep track of this, but the vv api requires the reader to populate the total number of values at the end of the batch.

It's possible to consolidate this if we some how get vv to use its writerIndex to populate valueCount, but this is ofcourse assuming they're writing serially into the batch.