Review Board 1.7.22


FLUME-2157. Spool directory source does not shut down correctly when Flume is reconfigured.

Review Request #13463 - Created Aug. 10, 2013 and updated

Mike Percy
FLUME-2157
Reviewers
Flume
flume-git
Spool directory source does not shut down correctly when Flume is reconfigured. This can lead to all sorts of problems stemming from the fact that we have threads running which should not be. In the logs, it looks like multiple spool directory sources are running on the same directory, even though the config may say otherwise.
Added a unit test for this specific case and also an integration test that simply runs an agent with many concurrent spool directory sources.
Posted (Aug. 12, 2013, 6:18 p.m.)
In SpoolDirectorySource.shitdown(), it might be useful to add  INFO or DEBUG level log indicating that it is waiting  ...  before entering a potentially 10 second long wait for the executor to wind up.

Looks good overall.
  1. of course i meant SpoolDirectorySource.shutdown()   :-)