Review Board 1.7.22


FLUME-2154 Reducing duplicate events caused by reset-connection-interval

Review Request #13436 - Created Aug. 9, 2013 and updated

Juhani Connolly
Reviewers
Flume
flume-git
I removed the lock and set a flag in scheduled runnable. This flag is checked in process and a reconnect is performed if set.
Unit tests were adjusted(since a reconnect requires process to actually happen) and pass. 

We tested with and without the patch on our servers and everything looks good with log duplication at the same level as having interval = 0
Total:
1
Open:
0
Resolved:
1
Dropped:
0
Status:
From:
Description From Last Updated Status
Review request changed
Updated (Aug. 9, 2013, 5:15 a.m.)
Added the requested changes.

The race condition you mentioned shouldn't be an issue.

Even as is the same situation would result in constantly queued resets, so the behavior now is probably preferable. Added some comments.
Ship it!
Posted (Aug. 9, 2013, 5:34 a.m.)
Ship It!