Review Board 1.7.22


HIVE-4545 - HS2 should return describe table results without space padding

Review Request #13383 - Created Aug. 7, 2013 and updated

Thejas Nair
HIVE-4545
Reviewers
hive
hive-git
HIVE-3140 changed behavior of 'DESCRIBE table;' to be like 'DESCRIBE FORMATTED table;'. HIVE-3140 introduced changes to not print header in 'DESCRIBE table;'. But jdbc/odbc calls still get fields padded with space for the 'DESCRIBE table;' query.

As the jdbc/odbc results are not for direct human consumption the space padding should not be done for hive server2.
Updated TestJdbcDriver2 unit tests
Total:
4
Open:
4
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (Jan. 31, 2014, 1:29 a.m.)
rebased to trunk
Posted (Jan. 31, 2014, 1:46 a.m.)

   

  
Do you think we should do this at HiveServer2 startup rather than at session level?
Posted (Jan. 31, 2014, 2:42 a.m.)
Overall looks good.
added very simple comments.
Should we specify the default to 'true' here as well?
I know it is done in HiveConf.java. Just to make sure.
So this is for only DESCRIBE TABLE. Doesn't have any meaning for other cases. right? In that case, rhe name of variable looks very generic for all cases. If it is only for MetaData level, can we use different name.
No usage/meaning in this MDFormatter . right?
Posted (Jan. 31, 2014, 3:04 a.m.)

   

  
need to update default site file too
What keeps anyone from setting this after the session has been established? Is there a way to determine whether you're running in HS2 or CLI? (and use that when printing?)
Posted (Jan. 31, 2014, 3:25 a.m.)

   

  
thats correct.