Review Board 1.7.22


SQOOP-921: Sqoop2: Create standalone shell package

Review Request #13338 - Created Aug. 6, 2013 and submitted

Mengwei Ding
SQOOP-921
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit 0ba78c6da15ad3a67bdec754025066abc4792eea
Author: Mengwei Ding <mengwei.ding@gmail.com>
Date:   Tue Aug 6 11:24:08 2013 -0700

    SQOOP-921: Sqoop2: Create standalone shell package

:100644 100644 c6351ed... 975773d... M	client/pom.xml
:000000 100644 0000000... aafb5b0... A	client/src/main/java/org/apache/sqoop/client/ClientError.java
:100644 100644 158e46c... f9e7ddd... M	client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 000000 d96f44e... 0000000... D	client/src/main/java/org/apache/sqoop/client/core/ClientError.java
:100644 000000 999790d... 0000000... D	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 befb793... d9229f5... M	client/src/main/java/org/apache/sqoop/client/request/Request.java
:100644 000000 283b025... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/CloneCommand.java
:100644 000000 0538901... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/CloneConnectionFunction.java
:100644 000000 6f62813... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/CloneJobFunction.java
:100644 000000 ac555e1... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/CreateCommand.java
:100644 000000 04b240c... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/CreateConnectionFunction.java
:100644 000000 cc4d546... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/CreateJobFunction.java
:100644 000000 6a5b3a1... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/DeleteCommand.java
:100644 000000 18d3a70... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/DeleteConnectionFunction.java
:100644 000000 736be20... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/DeleteJobFunction.java
:100644 000000 5cbd6db... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java
:100644 000000 e04292a... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java
:100644 000000 5962cd2... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java
:100644 000000 8a2c1c7... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java
:100644 000000 ed6dc3c... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java
:100644 000000 9e4e320... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java
:100644 000000 c6f831d... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/HelpCommand.java
:100644 000000 c831123... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SetCommand.java
:100644 000000 e843ede... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SetOptionFunction.java
:100644 000000 41fc17a... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SetServerFunction.java
:100644 000000 41a8cd3... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShellEnvironment.java
:100644 000000 4245717... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowCommand.java
:100644 000000 94f92b3... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 000000 b053339... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectorFunction.java
:100644 000000 58b2c6e... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowFrameworkFunction.java
:100644 000000 97a240b... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 000000 81c5612... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
:100644 000000 110f67e... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowServerFunction.java
:100644 000000 666eb7a... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowSubmissionFunction.java
:100644 000000 8e17f67... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/ShowVersionFunction.java
:100644 000000 2188482... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SqoopCommand.java
:100644 000000 bf26761... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SqoopFunction.java
:100644 000000 f4ea3be... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:100644 000000 7293f56... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/StartCommand.java
:100644 000000 2e1c8d3... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/StartJobFunction.java
:100644 000000 5aab035... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/StatusCommand.java
:100644 000000 b854a90... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/StatusJobFunction.java
:100644 000000 154c58e... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/StopCommand.java
:100644 000000 49ab461... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/StopJobFunction.java
:100644 000000 f16745c... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/UpdateCommand.java
:100644 000000 8556e2b... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/UpdateConnectionFunction.java
:100644 000000 425a53f... 0000000... D	client/src/main/java/org/apache/sqoop/client/shell/UpdateJobFunction.java
:100644 000000 b044e22... 0000000... D	client/src/main/java/org/apache/sqoop/client/utils/FormDisplayer.java
:100644 000000 2fbf129... 0000000... D	client/src/main/java/org/apache/sqoop/client/utils/FormFiller.java
:100644 000000 cbc956d... 0000000... D	client/src/main/java/org/apache/sqoop/client/utils/SubmissionDisplayer.java
:100644 000000 487fa50... 0000000... D	client/src/main/java/org/apache/sqoop/client/utils/TableDisplayer.java
:100644 000000 8a34f34... 0000000... D	client/src/main/java/org/apache/sqoop/client/utils/ThrowableDisplayer.java
:100644 000000 1a8f963... 0000000... D	client/src/main/resources/client-resource.properties
:100644 100644 dd67f85... 9186a38... M	dist/pom.xml
:100755 100755 88adb04... e3ed5ef... M	dist/src/main/bin/sqoop.sh
:100644 100644 5ea0633... 513b6d0... M	pom.xml
:000000 100644 0000000... 947eab0... A	shell/pom.xml
:000000 100644 0000000... 980a908... A	shell/src/main/java/org/apache/sqoop/shell/CloneCommand.java
:000000 100644 0000000... 856abaa... A	shell/src/main/java/org/apache/sqoop/shell/CloneConnectionFunction.java
:000000 100644 0000000... 3e23025... A	shell/src/main/java/org/apache/sqoop/shell/CloneJobFunction.java
:000000 100644 0000000... e62ce08... A	shell/src/main/java/org/apache/sqoop/shell/CreateCommand.java
:000000 100644 0000000... 5fbf0a3... A	shell/src/main/java/org/apache/sqoop/shell/CreateConnectionFunction.java
:000000 100644 0000000... 6e4f04b... A	shell/src/main/java/org/apache/sqoop/shell/CreateJobFunction.java
:000000 100644 0000000... abfcf2e... A	shell/src/main/java/org/apache/sqoop/shell/DeleteCommand.java
:000000 100644 0000000... c123732... A	shell/src/main/java/org/apache/sqoop/shell/DeleteConnectionFunction.java
:000000 100644 0000000... d4095b7... A	shell/src/main/java/org/apache/sqoop/shell/DeleteJobFunction.java
:000000 100644 0000000... 5a6d942... A	shell/src/main/java/org/apache/sqoop/shell/DisableCommand.java
:000000 100644 0000000... f119660... A	shell/src/main/java/org/apache/sqoop/shell/DisableConnectionFunction.java
:000000 100644 0000000... a87e51f... A	shell/src/main/java/org/apache/sqoop/shell/DisableJobFunction.java
:000000 100644 0000000... 3b8c0b1... A	shell/src/main/java/org/apache/sqoop/shell/EnableCommand.java
:000000 100644 0000000... f782b16... A	shell/src/main/java/org/apache/sqoop/shell/EnableConnectionFunction.java
:000000 100644 0000000... 20c80dc... A	shell/src/main/java/org/apache/sqoop/shell/EnableJobFunction.java
:000000 100644 0000000... e8d531f... A	shell/src/main/java/org/apache/sqoop/shell/HelpCommand.java
:000000 100644 0000000... 548def0... A	shell/src/main/java/org/apache/sqoop/shell/SetCommand.java
:000000 100644 0000000... 1c43dce... A	shell/src/main/java/org/apache/sqoop/shell/SetOptionFunction.java
:000000 100644 0000000... abd9cea... A	shell/src/main/java/org/apache/sqoop/shell/SetServerFunction.java
:000000 100644 0000000... 8be2e54... A	shell/src/main/java/org/apache/sqoop/shell/ShellEnvironment.java
:000000 100644 0000000... 672fa85... A	shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
:000000 100644 0000000... b7204ff... A	shell/src/main/java/org/apache/sqoop/shell/ShowConnectionFunction.java
:000000 100644 0000000... 97a4ab2... A	shell/src/main/java/org/apache/sqoop/shell/ShowConnectorFunction.java
:000000 100644 0000000... 28497db... A	shell/src/main/java/org/apache/sqoop/shell/ShowFrameworkFunction.java
:000000 100644 0000000... fc6f416... A	shell/src/main/java/org/apache/sqoop/shell/ShowJobFunction.java
:000000 100644 0000000... 5e3c3ff... A	shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java
:000000 100644 0000000... ec97e63... A	shell/src/main/java/org/apache/sqoop/shell/ShowServerFunction.java
:000000 100644 0000000... a592a98... A	shell/src/main/java/org/apache/sqoop/shell/ShowSubmissionFunction.java
:000000 100644 0000000... 764b754... A	shell/src/main/java/org/apache/sqoop/shell/ShowVersionFunction.java
:000000 100644 0000000... 241d120... A	shell/src/main/java/org/apache/sqoop/shell/SqoopCommand.java
:000000 100644 0000000... 675a796... A	shell/src/main/java/org/apache/sqoop/shell/SqoopFunction.java
:000000 100644 0000000... 900c0e5... A	shell/src/main/java/org/apache/sqoop/shell/SqoopShell.java
:000000 100644 0000000... f03e08f... A	shell/src/main/java/org/apache/sqoop/shell/StartCommand.java
:000000 100644 0000000... 02148de... A	shell/src/main/java/org/apache/sqoop/shell/StartJobFunction.java
:000000 100644 0000000... 184892a... A	shell/src/main/java/org/apache/sqoop/shell/StatusCommand.java
:000000 100644 0000000... be0de8c... A	shell/src/main/java/org/apache/sqoop/shell/StatusJobFunction.java
:000000 100644 0000000... 698bca7... A	shell/src/main/java/org/apache/sqoop/shell/StopCommand.java
:000000 100644 0000000... 6c0e3c2... A	shell/src/main/java/org/apache/sqoop/shell/StopJobFunction.java
:000000 100644 0000000... 9262ccd... A	shell/src/main/java/org/apache/sqoop/shell/UpdateCommand.java
:000000 100644 0000000... c062fe6... A	shell/src/main/java/org/apache/sqoop/shell/UpdateConnectionFunction.java
:000000 100644 0000000... da1e0c5... A	shell/src/main/java/org/apache/sqoop/shell/UpdateJobFunction.java
:000000 100644 0000000... 0e33d42... A	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:000000 100644 0000000... e5a99f1... A	shell/src/main/java/org/apache/sqoop/shell/core/ShellError.java
:000000 100644 0000000... 56e0b4e... A	shell/src/main/java/org/apache/sqoop/shell/utils/FormDisplayer.java
:000000 100644 0000000... 9bc0b93... A	shell/src/main/java/org/apache/sqoop/shell/utils/FormFiller.java
:000000 100644 0000000... 1f61fb2... A	shell/src/main/java/org/apache/sqoop/shell/utils/SubmissionDisplayer.java
:000000 100644 0000000... 51030d0... A	shell/src/main/java/org/apache/sqoop/shell/utils/TableDisplayer.java
:000000 100644 0000000... 6026a95... A	shell/src/main/java/org/apache/sqoop/shell/utils/ThrowableDisplayer.java
:000000 100644 0000000... af7e9f3... A	shell/src/main/resources/log4j.properties
:000000 100644 0000000... 1a8f963... A	shell/src/main/resources/shell-resource.properties
:000000 100644 0000000... 44ffced... A	shell/src/test/resources/log4j.properties
Major changes:

1. move out the original client.shell, client.utils and client.core package to a whole new module 'shell'

2. update pom.xml files of client and shell modules to keep dependencies only necessary

3. update the bin/sqoop.sh to make the script keep align with module changes

Please ignore all java files, because I did nothing to them. Except that, please take a look at the Error.java files, cause I have to separate error codes for these two modules.
Review request changed
Updated (Aug. 7, 2013, 9:36 p.m.)
  • changed from pending to submitted