Review Board 1.7.22


SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used

Review Request #13273 - Created Aug. 5, 2013 and updated

Mengwei Ding
SQOOP-1162
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit 894e2fe8b01cd1d12f4f8e9377a60707a22faf04
Author: Mengwei Ding <mengwei.ding@gmail.com>
Date:   Mon Aug 5 10:47:29 2013 -0700

    SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used

:100644 100644 672fa85... 0520bfa... M	shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
:100644 100644 5e3c3ff... 6c8cb0f... M	shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java
:100644 100644 475f41c... f7d02e5... M	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
:100644 100644 df9457d... fd268b0... M	shell/src/main/resources/shell-resource.properties

 
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Review request changed
Updated (Aug. 19, 2013, 9:17 p.m.)
  • commit 64ebb185e42578ec0138639780e4953e22d4cff9
    Author: Mengwei Ding <mengwei.ding@gmail.com>
    Date:   Mon Aug 5 10:47:29 2013 -0700
    
        SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used
    
    :100644 100644 999790d... 7ebd4d3... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
    :100644 100644 81c5612... 36b3ae8... M	client/src/main/java/org/apache/sqoop/client/shell/ShowOptionFunction.java
    :100644 100644 1a8f963... 610b6b2... M	client/src/main/resources/client-resource.properties

    commit 894e2fe8b01cd1d12f4f8e9377a60707a22faf04
    Author: Mengwei Ding <mengwei.ding@gmail.com>
    Date:   Mon Aug 5 10:47:29 2013 -0700
    
        SQOOP-1162: Sqoop2: 'show option' should have help entry showing that 'all' arg can be used
    
    :100644 100644 672fa85... 0520bfa... M	shell/src/main/java/org/apache/sqoop/shell/ShowCommand.java
    :100644 100644 5e3c3ff... 6c8cb0f... M	shell/src/main/java/org/apache/sqoop/shell/ShowOptionFunction.java
    :100644 100644 475f41c... f7d02e5... M	shell/src/main/java/org/apache/sqoop/shell/core/Constants.java
    :100644 100644 df9457d... fd268b0... M	shell/src/main/resources/shell-resource.properties
Improved the help message for "show" command. Elaborate the usages of all its sub functions.
Posted (Aug. 24, 2013, 9:05 p.m.)
Hi Mengwei,
thank you for rebasing the patch and adding the additional features.
The help text displaying is not currently ideal and we already do have couple of JIRAs solving it - for example SQOOP-965 or SQOOP-819.

As this code change would make one command behave differently then the others, can we solve the original problem of the JIRA and let the help text be solved by the other JIRAs?
Jarcec