Review Board 1.7.22


HIVE-4850 Implement vector mode map join

Review Request #13059 - Created July 30, 2013 and submitted

Remus Rusanu
trunk
HIVE-4850
Reviewers
hive
hanson5b, jitendra
hive-git
This is a working implementation based on current trunk. It is simpler than the .1 patch in as it delegates the JOIN entirely to the row-mode MapJoinOperator. The vectorized operator is literally calling the row-mode implementaiton for each row in the input batch and collects the row-mode forward into the output batch. This is not as bad as it seems because the JOIN operators has to resort to row-mode operations anyway, due to the small tables (hashtables) being row-mode (objects and object-inspectors). By delegating the entire join logic to the row mode we piggyback on the correctness of exiting implementation. I do plan to come up with a full-vectorized mode implementation but that would require changes to the hash table creation-serialization. Note that the filtering and key evaluation of the big table does use vectorized operators. the row mode applies only to the key HT lookup and to the JOIN logic
Manually run some join queries on alltypes_orc table.
Total:
17
Open:
17
Resolved:
0
Dropped:
0
Status:
From:
Description From Last Updated Status
Nice to see good comments Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
A comment that explains at a high level where and how this interface is used would be helpful. Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
should these fields be marked private? Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a comment that explains this method. Should this be a new method on ByteColumnVector or can you use ... Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a comment to explain the purpose of this method Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
conventions are to put blanks before and after operators =, < etc. Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
The Sun Java coding style conventions that are used for Hive say to use this style: } else [if (...)] ... Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a descriptive comment for this method Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
and the what? Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
remove blank comment? Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
correct spelling of Vectorization Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
supper -> super? Please explain what out-of-band params are. Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
colon should be surounded by blanks Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a comment that describes what this method does. Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a comment Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a comment explaining what's done by this method Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Please add a descriptive comment for this method Eric Hanson Nov. 11, 2013, 8:08 p.m. Open
Review request changed
Updated (Feb. 12, 2014, 12:41 p.m.)
  • changed from pending to submitted