Review Board 1.7.22


Implement IsNull and IsNotNull DrillFunctions

Review Request #13029 - Created July 29, 2013 and updated

Ben Becker
master
Reviewers
drill-git
drill-git
Implements IsNull and IsNotNull DrillFunctions with simple tests.

Also fixes a few tangential bugs.  To view in Github, see https://github.com/vrtx/incubator-drill/commits/NullOp.

 
Total:
1
Open:
1
Resolved:
0
Dropped:
0
Status:
From:
Posted (July 30, 2013, 1:02 a.m.)

   

  
This assignment is unnecessary.  Valuecount shouldn't be set at allocation time.  It is set once you fill up the vector and decide how many values it should hold.
This seems like a common situation.  Any way we can abstract this so we can easily write lots of function tests without repeating ourselves?
Posted (July 30, 2013, 1:04 a.m.)

   

  
Any reason we want to keep this checked in?