Review Board 1.7.22


ZOOKEEPER-1691

Review Request #12983 - Created July 26, 2013 and updated

Helen Hastings
Reviewers
zookeeper
shralex
zookeeper
Added standaloneEnabled flag to QuorumPeerConfig to give the option to disable standalone mode for a single server.

 
Total:
26
Open:
6
Resolved:
20
Dropped:
0
Status:
From:
Description From Last Updated Status
please do testNormaOperaton Alexander Shraer Aug. 19, 2013, 5:49 p.m. Open
Please, remove those spaces (red bars) as much as possible. In this particular line, they were introduced. Edward Ribeiro Aug. 20, 2013, 12:39 a.m. Open
Why did you renamed quorumVerifier to qv? It's a good practice to let the full name as opposed to initials ... Edward Ribeiro Aug. 20, 2013, 2:31 a.m. Open
Can you please explain why termPredicate doesn't work in this case, requiring this fix ? Where do you check that ... Alexander Shraer Aug. 30, 2013, 11:11 a.m. Open
Hi Helen, What I would expect to happen in the scenario you described is the following: the joining server has ... Alexander Shraer Oct. 3, 2013, 4:54 a.m. Open
nit: you can use String.format to make building up this line more readable. http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29 Raul Gutierrez Segales Jan. 17, 2014, 6:51 p.m. Open
Review request changed
Updated (Jan. 7, 2014, 4:32 a.m.)
Posted (Jan. 17, 2014, 6:51 p.m.)

   

  
nit: if you check all the files in this dir, all the tests are called testFooBar(). Might be good to follow the convention.

See: https://github.com/apache/zookeeper/tree/trunk/src/java/test/org/apache/zookeeper/server/quorum
nit: string extrapolation reads more clearly than concatenating strings.

I.e.:

LOG.info("Initial configuration: {}\n", zkHandles[leaderId].getConfig(this, new Stat()));

Plus the cast to string happens for free. Ditto for all other calls to LOG methods.  
nit: you can use String.format to make building up this line more readable.

http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29
nit: you can use String.format to make building up this line more readable.

http://docs.oracle.com/javase/7/docs/api/java/lang/String.html#format%28java.lang.String,%20java.lang.Object...%29