Review Board 1.7.22


AsyncHbase Sink bugfix plus tests errors on Windows

Review Request #12889 - Created July 24, 2013 and updated

Roshan Naik
flume-1.5
FLUME-2134
Reviewers
Flume
flume-git
1) The Async HBase sink uses conf.get("hbase.zookeeper.quorum") to get the zookeeper quorum info... which on windows is only returning "localhost". HBase folks advised the use of  ZKConfig.getZKQuorumServersString(conf) instead. I confirmed it returns the right value  "localhost:port#" on both Windows and Linux.

2) Setup code in Async HBase Sink tests are simplified to use testUtility provided by HBase to spin up a HBase cluster. The Temporary directory creation in the old code caused problems when used by HBase, if the directory name had a space in it. 
Tests pass both on Linux and Windows.
Ship it!
Posted (July 24, 2013, 7:36 a.m.)
Good catch. Thanks, Roshan
Ship it!
Posted (July 24, 2013, 7:36 a.m.)
Good catch. Thanks, Roshan
Ship it!
Posted (July 24, 2013, 7:36 a.m.)
Good catch. Thanks, Roshan