Review Board 1.7.22


SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

Review Request #12593 - Created July 16, 2013 and submitted

Mengwei Ding
SQOOP-1141
Reviewers
Sqoop
abe, hshreedharan, jarcec
sqoop-sqoop2
commit a3c6f9d77694936a30f4cbef97ede6954aba4004
Author: Mengwei Ding <mengwei.ding@gmail.com>
Date:   Tue Jul 16 10:41:12 2013 -0700

    SQOOP-1141 Sqoop2: Provide ability to enable/disable connections and jobs

:100644 100644 4ca71a4... 158e46c... M	client/src/main/java/org/apache/sqoop/client/SqoopClient.java
:100644 100644 b7b0436... 999790d... M	client/src/main/java/org/apache/sqoop/client/core/Constants.java
:100644 100644 a69e009... f523abb... M	client/src/main/java/org/apache/sqoop/client/request/ConnectionRequest.java
:100644 100644 55ba9db... 6dee2c8... M	client/src/main/java/org/apache/sqoop/client/request/JobRequest.java
:100644 100644 f102c8f... ffaa84f... M	client/src/main/java/org/apache/sqoop/client/request/SqoopRequests.java
:000000 100644 0000000... 5cbd6db... A	client/src/main/java/org/apache/sqoop/client/shell/DisableCommand.java
:000000 100644 0000000... e04292a... A	client/src/main/java/org/apache/sqoop/client/shell/DisableConnectionFunction.java
:000000 100644 0000000... 5962cd2... A	client/src/main/java/org/apache/sqoop/client/shell/DisableJobFunction.java
:000000 100644 0000000... 8a2c1c7... A	client/src/main/java/org/apache/sqoop/client/shell/EnableCommand.java
:000000 100644 0000000... ed6dc3c... A	client/src/main/java/org/apache/sqoop/client/shell/EnableConnectionFunction.java
:000000 100644 0000000... 9e4e320... A	client/src/main/java/org/apache/sqoop/client/shell/EnableJobFunction.java
:100644 100644 32bca71... 94f92b3... M	client/src/main/java/org/apache/sqoop/client/shell/ShowConnectionFunction.java
:100644 100644 590e4e7... 97a240b... M	client/src/main/java/org/apache/sqoop/client/shell/ShowJobFunction.java
:100644 100644 aa87f20... f4ea3be... M	client/src/main/java/org/apache/sqoop/client/shell/SqoopShell.java
:100644 100644 5537a8e... 1a8f963... M	client/src/main/resources/client-resource.properties
:100644 100644 b4e986a... a014ddd... M	common/src/main/java/org/apache/sqoop/json/ConnectionBean.java
:100644 100644 a830646... 4685797... M	common/src/main/java/org/apache/sqoop/json/JobBean.java
:100644 100644 98768d6... ba12b39... M	common/src/main/java/org/apache/sqoop/json/util/FormSerialization.java
:100644 100644 137e71c... 5524983... M	common/src/main/java/org/apache/sqoop/model/MAccountableEntity.java
:100644 100644 dd1d75b... 2f2b974... M	common/src/test/java/org/apache/sqoop/json/TestConnectionBean.java
:100644 100644 6af1d8b... e42b7df... M	common/src/test/java/org/apache/sqoop/json/TestJobBean.java
:100644 100644 4ea42b1... bf103e4... M	common/src/test/java/org/apache/sqoop/model/TestMAccountableEntity.java
:100644 100644 4277311... f7a6b67... M	core/src/main/java/org/apache/sqoop/framework/FrameworkError.java
:100644 100644 9f09982... d0a087d... M	core/src/main/java/org/apache/sqoop/framework/JobManager.java
:100644 100644 095f3e9... 7768b13... M	core/src/main/java/org/apache/sqoop/repository/JdbcRepository.java
:100644 100644 d468b79... 9299484... M	core/src/main/java/org/apache/sqoop/repository/JdbcRepositoryHandler.java
:100644 100644 92e11d2... 7c7673f... M	core/src/main/java/org/apache/sqoop/repository/Repository.java
:100644 100644 aeb7533... 455eb64... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepoError.java
:100644 100644 f717abf... 771673d... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbyRepositoryHandler.java
:100644 100644 68cb1c0... 49bf607... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaConstants.java
:100644 100644 b2cd6cc... b08f7ab... M	repository/repository-derby/src/main/java/org/apache/sqoop/repository/derby/DerbySchemaQuery.java
:100644 100644 677b0be... b766b09... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/DerbyTestCase.java
:100644 100644 8266b46... 6959f2d... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestConnectionHandling.java
:100644 100644 4c97e1e... a3d804e... M	repository/repository-derby/src/test/java/org/apache/sqoop/repository/derby/TestJobHandling.java
:100644 100644 038f602... 62be8f4... M	server/src/main/java/org/apache/sqoop/handler/ConnectionRequestHandler.java
:100644 100644 ab3f9d0... 0d15329... M	server/src/main/java/org/apache/sqoop/handler/JobRequestHandler.java
Did some manual tests to check whether job could be started if either job or connection has been disabled.
Total:
3
Open:
0
Resolved:
3
Dropped:
0
Status:
From:
Review request changed
Updated (July 29, 2013, 4:44 p.m.)
  • changed from pending to submitted