Review Board 1.7.22


SQOOP-1136: Sqoop2: MBooleanInput should copy persistenceId when do clone()

Review Request #12522 - Created July 12, 2013 and submitted

Mengwei Ding
SQOOP-1136
Reviewers
Sqoop
jarcec
sqoop-sqoop2
commit aed85ad9b7b6593313b8ec77eac475c9e2401fb9
Author: Mengwei Ding <mengwei.ding@gmail.com>
Date:   Fri Jul 12 14:55:23 2013 -0700

    SQOOP-1136: Sqoop2: MBooleanInput should copy persistenceId when do clone()

:100644 100644 68142da... da380dd... M	common/src/main/java/org/apache/sqoop/model/MBooleanInput.java

 

Diff revision 1 (Latest)

  1. common/src/main/java/org/apache/sqoop/model/MBooleanInput.java: Loading...
common/src/main/java/org/apache/sqoop/model/MBooleanInput.java
Revision 68142da New Change
[20] 71 lines
[+20] [+] public void setEmpty() {
72
  }
72
  }
73

    
   
73

   
74
  @Override
74
  @Override
75
  public Object clone(boolean cloneWithValue) {
75
  public Object clone(boolean cloneWithValue) {
76
    MBooleanInput copy = new MBooleanInput(getName(), isSensitive());
76
    MBooleanInput copy = new MBooleanInput(getName(), isSensitive());

    
   
77
    copy.setPersistenceId(this.getPersistenceId());
77
    if(cloneWithValue) {
78
    if(cloneWithValue) {
78
      copy.setValue(getValue());
79
      copy.setValue(getValue());
79
    }
80
    }
80
    return copy;
81
    return copy;
81
  }
82
  }
82
}
83
}
  1. common/src/main/java/org/apache/sqoop/model/MBooleanInput.java: Loading...