Review Board 1.7.22


SQOOP-1131 New test added in SQOOP-1121 is using unsupported API in Hadoop 100

Review Request #12457 - Created July 10, 2013 and updated

Jarek Cecho
SQOOP-1131
Reviewers
Sqoop
sqoop-sqoop2
I've used API compatible with both Hadoop 1.x and 2.x.
Tests seems to be passing in both profiles (100, 200).
execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java
Revision 5e2d099f7b0d26292c5265690bf11568e1e6ffcd New Change
[20] 48 lines
[+20] [+] public class TestConfigurationUtils {
49
    setUpJob();
49
    setUpJob();
50
    setUpJobConf();
50
    setUpJobConf();
51
  }
51
  }
52

    
   
52

   
53
  public void setUpJob() throws Exception {
53
  public void setUpJob() throws Exception {
54
    job = Job.getInstance();
54
    job = new Job();
55
  }
55
  }
56

    
   
56

   
57
  public void setUpJobConf() throws Exception {
57
  public void setUpJobConf() throws Exception {
58
    jobConf = spy(new JobConf(job.getConfiguration()));
58
    jobConf = spy(new JobConf(job.getConfiguration()));
59
    when(jobConf.getCredentials()).thenReturn(job.getCredentials());
59
    when(jobConf.getCredentials()).thenReturn(job.getCredentials());
[+20] [20] 121 lines
  1. execution/mapreduce/src/test/java/org/apache/sqoop/job/mr/TestConfigurationUtils.java: Loading...