Review Board 1.7.22


SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

Review Request #12451 - Created July 10, 2013 and submitted

Mengwei Ding
SQOOP-1049
Reviewers
Sqoop
jarcec
sqoop-sqoop2
commit c41d3e475700c4d2f97606b153d75a86ef543cf4
Author: Mengwei Ding <mengwei.ding@gmail.com>
Date:   Wed Jul 10 11:41:05 2013 -0700

    SQOOP-1049: Sqoop2: Record not imported if partition column value is NULL

:100644 100644 f3dee8e... 27db8af... M	common/src/main/java/org/apache/sqoop/model/FormUtils.java
:100644 100644 7792c57... 8d0c4ab... M	connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
:100644 100644 ef27236... 0991b28... M	connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/configuration/ImportTableForm.java
:100644 100644 44fc984... 0950e32... M	connector/connector-generic-jdbc/src/main/resources/generic-jdbc-connector-resources.properties
:100644 100644 7ecc900... a33dd6c... M	connector/connector-generic-jdbc/src/test/java/org/apache/sqoop/connector/jdbc/TestImportPartitioner.java
Have done a manual test, in which I successfully import a table with some null values in partition column.
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java
Revision abcc89d New Change
[20] 38 lines
[+20]
39
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.columntype";
39
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.columntype";
40
  public static final String CONNECTOR_JDBC_PARTITION_MINVALUE =
40
  public static final String CONNECTOR_JDBC_PARTITION_MINVALUE =
41
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.minvalue";
41
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.minvalue";
42
  public static final String CONNECTOR_JDBC_PARTITION_MAXVALUE =
42
  public static final String CONNECTOR_JDBC_PARTITION_MAXVALUE =
43
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.maxvalue";
43
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.maxvalue";

    
   
44
  public static final String CONNECTOR_JDBC_PARTITION_HASNULL =

    
   
45
      PREFIX_CONNECTOR_JDBC_CONFIG + "partition.hasnull";
44

    
   
46

   
45
  public static final String CONNECTOR_JDBC_DATA_SQL =
47
  public static final String CONNECTOR_JDBC_DATA_SQL =
46
      PREFIX_CONNECTOR_JDBC_CONFIG + "data.sql";
48
      PREFIX_CONNECTOR_JDBC_CONFIG + "data.sql";
47

    
   
49

   
48
  public static final String SQL_CONDITIONS_TOKEN = "${CONDITIONS}";
50
  public static final String SQL_CONDITIONS_TOKEN = "${CONDITIONS}";
[+20] [20] 11 lines
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java
Revision 671bb4a New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java
Revision 96818ba New Change
 
connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java
Revision 4401800 New Change
 
  1. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorConstants.java: Loading...
  2. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcConnectorError.java: Loading...
  3. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportInitializer.java: Loading...
  4. connector/connector-generic-jdbc/src/main/java/org/apache/sqoop/connector/jdbc/GenericJdbcImportPartitioner.java: Loading...