Review Board 1.7.22


Cheolsoo Park got review request #12321!

PIG-3021 Split results missing records when there is null values in the column comparison

Review Request #12321 - Created July 7, 2013 and updated

Cheolsoo Park
PIG-3021
Reviewers
pig
pig-git
Introduced a new optional keyword (ALL) into the split otherwise. If ALL is specified, null values are stored into the default relation. Otherwise, nulls are discarded. By default, ALL is not specified.
Added a test case to TestSplit regarding the new keyword.

ant test -Dtestcase=TestSplit passes.
src/docs/src/documentation/content/xdocs/basic.xml
Revision e78bbd8 New Change
[20] 7554 lines
[+20]
7555
   <section>
7555
   <section>
7556
   <title>Syntax</title>
7556
   <title>Syntax</title>
7557
   <table>
7557
   <table>
7558
      <tr> 
7558
      <tr> 
7559
            <td>
7559
            <td>
7560
               <p>SPLIT alias INTO alias IF expression, alias IF expression [, alias IF expression …] [, alias OTHERWISE];</p>
7560
               <p>SPLIT alias INTO alias IF expression, alias IF expression [, alias IF expression …] [, alias OTHERWISE [ALL] ];</p>
7561
            </td>
7561
            </td>
7562
         </tr> 
7562
         </tr> 
7563
   </table></section>
7563
   </table></section>
7564
   
7564
   
7565
   <section>
7565
   <section>
[+20] [20] 31 lines
[+20]
7597
               <p>An expression.</p>
7597
               <p>An expression.</p>
7598
            </td>
7598
            </td>
7599
         </tr> 
7599
         </tr> 
7600
           <tr>
7600
         <tr>
7601
            <td>
7601
            <td>
7602
               <p>OTHERWISE</p>
7602
               <p>OTHERWISE [ALL]</p>
7603
            </td>
7603
            </td>
7604
            <td>
7604
            <td>
7605
               <p>Optional keyword. Designates a default relation.</p>
7605
               <p>

    
   
7606
               Optional keyword. Designates a default relation. If ALL is specified, all the

    
   
7607
               records including nulls are stored in the default relation; otherwise, nulls

    
   
7608
               are discarded.

    
   
7609
               </p>
7606
            </td>
7610
            </td>
7607
         </tr>
7611
         </tr>
7608
   </table></section>
7612
   </table></section>
7609
   
7613
   
7610
   <section>
7614
   <section>
[+20] [20] 949 lines
src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POIsNull.java
Revision 4b38b45 New Change
 
src/org/apache/pig/parser/AstPrinter.g
Revision ccccd87 New Change
 
src/org/apache/pig/parser/AstValidator.g
Revision d0ed0e8 New Change
 
src/org/apache/pig/parser/LogicalPlanBuilder.java
Revision 99e481d New Change
 
src/org/apache/pig/parser/LogicalPlanGenerator.g
Revision b13f346 New Change
 
src/org/apache/pig/parser/QueryParser.g
Revision d4d9700 New Change
 
test/org/apache/pig/test/TestSplit.java
Revision 8794110 New Change
 
  1. src/docs/src/documentation/content/xdocs/basic.xml: Loading...
  2. src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/POIsNull.java: Loading...
  3. src/org/apache/pig/parser/AstPrinter.g: Loading...
  4. src/org/apache/pig/parser/AstValidator.g: Loading...
  5. src/org/apache/pig/parser/LogicalPlanBuilder.java: Loading...
  6. src/org/apache/pig/parser/LogicalPlanGenerator.g: Loading...
  7. src/org/apache/pig/parser/QueryParser.g: Loading...
  8. test/org/apache/pig/test/TestSplit.java: Loading...