Review Board 1.7.22


SQOOP-1124: Direct export to PostgreSQL with PGBulkloadManager fails without explicit port number settings

Review Request #12269 - Created July 4, 2013 and updated

Masatake Iwasaki
trunk
SQOOP-1124
Reviewers
Sqoop
sqoop-trunk
Attached patch includes following changes:
1. handling for the case JdbcUrl.getPort returns -1 is added to PGBulkloadExportMapper,
2. settings for PGBulkloadManagerManualTest such as database, and username ,tablespace and path of pg_bulkload are made configurable via system property,
3. using not Configuration but JobConf in PGBulkloadManagerManualTest to follow changes in DBConfiguration.
passed PGBulkloadManagerManualTest on PostgreSQL 9.2.4 and pg_bulkload 3.1.3.
Review request changed
Updated (July 10, 2013, 5:51 a.m.)
Ship it!
Posted (July 10, 2013, 3:25 p.m.)
The changes looks good to me, please upload the patch to the JIRA, so that I can commit it!