Review Board 1.7.22


SQOOP-1118: Move PostgreSQL specific MR codes to org.apache.sqoop.mapreduce.posgresql

Review Request #12240 - Created July 3, 2013 and updated

Masatake Iwasaki
SQOOP-1118
Reviewers
Sqoop
sqoop-trunk
Attached patch includes following changes:
1. codes in org.apache.sqoop.mapreduce are moved to org.apache.sqoop.mapreduce.postgresql,
2. settings for PGBulkloadManagerManualTest such as database, and username ,tablespace and path of pg_bulkload are made configurable via system property,
3. using not Configuration but JobConf in PGBulkloadManagerManualTest to follow changes in DBConfiguration,
4. handling for the case JdbcUrl.getPort returns -1 is added to PGBulkloadExportMapper.
passed PGBulkloadManagerManualTest on PostgreSQL 9.2.4 and pg_bulkload 3.1.3.
src/java/org/apache/sqoop/manager/PGBulkloadManager.java
Revision 091fd15 New Change
[20] 23 lines
[+20]
24
import com.cloudera.sqoop.util.ExportException;
24
import com.cloudera.sqoop.util.ExportException;
25
import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
25
import org.apache.hadoop.mapreduce.lib.output.NullOutputFormat;
26
import org.apache.commons.logging.Log;
26
import org.apache.commons.logging.Log;
27
import org.apache.commons.logging.LogFactory;
27
import org.apache.commons.logging.LogFactory;
28
import org.apache.sqoop.mapreduce.ExportInputFormat;
28
import org.apache.sqoop.mapreduce.ExportInputFormat;
29
import org.apache.sqoop.mapreduce.PGBulkloadExportJob;
29
import org.apache.sqoop.mapreduce.postgresql.PGBulkloadExportJob;
30

    
   
30

   
31

    
   
31

   
32

    
   
32

   
33
/**
33
/**
34
 * Manages connections to Postgresql databases.
34
 * Manages connections to Postgresql databases.
[+20] [20] 32 lines
src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java
Revision cc60233 New Change
 
src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java
Revision 81b1333 New Change
 
src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java
Revision 6f55861 New Change
 
src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java
New File
 
src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportMapper.java
New File
 
src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportReducer.java
New File
 
  1. src/java/org/apache/sqoop/manager/PGBulkloadManager.java: Loading...
  2. src/java/org/apache/sqoop/mapreduce/PGBulkloadExportJob.java: Loading...
  3. src/java/org/apache/sqoop/mapreduce/PGBulkloadExportMapper.java: Loading...
  4. src/java/org/apache/sqoop/mapreduce/PGBulkloadExportReducer.java: Loading...
  5. src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportJob.java: Loading...
  6. src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportMapper.java: Loading...
  7. src/java/org/apache/sqoop/mapreduce/postgresql/PGBulkloadExportReducer.java: Loading...